applied patch [SF#236087]

Author: Richard Jones

CHANGES.txt

@@ -6,6 +6,8 @@ Feature:
 - added "imapServer.py" script (sf patch 934567)
 - added date selection popup windows (thanks Marcus Priesch)
 - added Xapian indexer; replaces standard indexers if Xapian is available
+- refactored hyperdb.rawToHyperdb, allowing a number of improvements
+  (thanks Ralf Schlatterbeck)
 
 
 2005-??-?? 0.8.4

doc/index.txt

@@ -129,6 +129,7 @@ John P. Rouillard,
 Ollie Rutherfurd,
 Toby Sargeant,
 Giuseppe Scelsi,
+Ralf Schlatterbeck,
 Gregor Schmid,
 Florian Schulze,
 Klamer Schutte,

roundup/admin.py

@@ -16,7 +16,7 @@
 # BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE,
 # SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
 #
-# $Id: admin.py,v 1.95 2005-06-24 05:32:56 richard Exp $
+# $Id: admin.py,v 1.96 2005-07-12 01:37:49 richard Exp $
 
 '''Administration commands for maintaining Roundup trackers.
 '''
@@ -571,7 +571,7 @@ def do_get(self, args):
         return 0
 
 
-    def do_set(self, args, pwre = re.compile(r'{(\w+)}(.+)')):
+    def do_set(self, args):
         ""'''Usage: set items property=value property=value ...
         Set the given properties of one or more items(s).
 
@@ -732,7 +732,7 @@ def do_display(self, args):
                 value = cl.get(nodeid, key)
                 print _('%(key)s: %(value)r')%locals()
 
-    def do_create(self, args, pwre = re.compile(r'{(\w+)}(.+)')):
+    def do_create(self, args):
         ""'''Usage: create classname property=value ...
         Create a new entry of a given class.
 

roundup/backends/back_anydbm.py

@@ -15,7 +15,7 @@
 # BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE,
 # SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
 #
-#$Id: back_anydbm.py,v 1.187 2005-04-28 00:21:42 richard Exp $
+#$Id: back_anydbm.py,v 1.188 2005-07-12 01:37:49 richard Exp $
 '''This module defines a backend that saves the hyperdatabase in a
 database chosen by anydbm. It is guaranteed to always be available in python
 versions >2.1.1 (the dumbdbm fallback in 2.1.1 and earlier has several
@@ -1592,7 +1592,6 @@ def filter(self, search_matches, filterspec, sort=(None,None),
         INTERVAL = 'spec:interval'
         OTHER = 'spec:other'
 
-        timezone = self.db.getUserTimezone()
         for k, v in filterspec.items():
             propclass = props[k]
             if isinstance(propclass, hyperdb.Link):
@@ -1623,7 +1622,7 @@ def filter(self, search_matches, filterspec, sort=(None,None),
                     l.append((STRING, k, re.compile(v, re.I)))
             elif isinstance(propclass, hyperdb.Date):
                 try:
-                    date_rng = date.Range(v, date.Date, offset=timezone)
+                    date_rng = propclass.range_from_raw (v, self.db)
                     l.append((DATE, k, date_rng))
                 except ValueError:
                     # If range creation fails - ignore that search parameter

roundup/backends/back_metakit.py

@@ -1,4 +1,4 @@
-# $Id: back_metakit.py,v 1.96 2005-06-24 06:38:14 richard Exp $
+# $Id: back_metakit.py,v 1.97 2005-07-12 01:37:49 richard Exp $
 '''Metakit backend for Roundup, originally by Gordon McMillan.
 
 Known Current Bugs:
@@ -1209,8 +1209,6 @@ def filter(self, search_matches, filterspec, sort=(None,None),
         if __debug__:
             start_t = time.time()
 
-        timezone = self.db.getUserTimezone()
-
         where = {'_isdel':0}
         wherehigh = {}
         mlcriteria = {}
@@ -1277,7 +1275,7 @@ def filter(self, search_matches, filterspec, sort=(None,None),
             elif isinstance(prop, hyperdb.Date):
                 try:
                     # Try to filter on range of dates
-                    date_rng = Range(value, date.Date, offset=timezone)
+                    date_rng = prop.range_from_raw (value, self.db)
                     if date_rng.from_value:
                         t = date_rng.from_value.get_tuple()
                         where[propname] = int(calendar.timegm(t))

roundup/backends/back_mysql.py

@@ -1,4 +1,4 @@
-#$Id: back_mysql.py,v 1.58 2005-05-02 05:48:59 richard Exp $
+#$Id: back_mysql.py,v 1.59 2005-07-12 01:37:49 richard Exp $
 #
 # Copyright (c) 2003 Martynas Sklyzmantas, Andrey Lebedev <[email protected]>
 #
@@ -521,8 +521,6 @@ def filter(self, search_matches, filterspec, sort=(None,None),
 
         cn = self.classname
 
-        timezone = self.db.getUserTimezone()
-
         # vars to hold the components of the SQL statement
         frum = ['_'+cn] # FROM clauses
         loj = []        # LEFT OUTER JOIN clauses
@@ -617,7 +615,7 @@ def filter(self, search_matches, filterspec, sort=(None,None),
                 else:
                     try:
                         # Try to filter on range of dates
-                        date_rng = Range(v, date.Date, offset=timezone)
+                        date_rng = propclass.range_from_raw (v, self.db)
                         if date_rng.from_value:
                             where.append('_%s._%s >= %s'%(cn, k, a))
                             args.append(dc(date_rng.from_value))

roundup/backends/rdbms_common.py

@@ -1,4 +1,4 @@
-# $Id: rdbms_common.py,v 1.156 2005-06-24 06:38:14 richard Exp $
+# $Id: rdbms_common.py,v 1.157 2005-07-12 01:37:50 richard Exp $
 ''' Relational database (SQL) backend common code.
 
 Basics:
@@ -2061,8 +2061,6 @@ def filter(self, search_matches, filterspec, sort=(None,None),
 
         cn = self.classname
 
-        timezone = self.db.getUserTimezone()
-
         # vars to hold the components of the SQL statement
         frum = []       # FROM clauses
         loj = []        # LEFT OUTER JOIN clauses
@@ -2151,7 +2149,7 @@ def filter(self, search_matches, filterspec, sort=(None,None),
                 else:
                     try:
                         # Try to filter on range of dates
-                        date_rng = Range(v, date.Date, offset=timezone)
+                        date_rng = propclass.range_from_raw (v, self.db)
                         if date_rng.from_value:
                             where.append('_%s._%s >= %s'%(cn, k, a))
                             args.append(dc(date_rng.from_value))

roundup/cgi/templating.py

@@ -1397,6 +1397,8 @@ def __init__(self, client, classname, nodeid, prop, name, value,
                 isinstance(self._value, unicode)):
             self._value.setTranslator(self._client.translator)
         self._offset = offset
+        if self._offset is None :
+            self._offset = self._prop.offset (self._db)
 
     def plain(self):
         ''' Render a "plain" representation of the property
@@ -1481,8 +1483,11 @@ def field(self, size=30, default=None, format=_marker):
             else:
                 value = date.Date(raw_value).pretty(format)
         else:
-            tz = self._db.getUserTimezone()
-            value = raw_value.local(tz)
+            if self._offset is None :
+                offset = self._db.getUserTimezone()
+            else :
+                offset = self._offset
+            value = raw_value.local(offset)
             if format is not self._marker:
                 value = value.pretty(format)