Skip to content

Commit 692312d

Browse files
author
Richard Jones
committed
fix nested scope bug in multilink sorting in rdbms filtering
1 parent c338508 commit 692312d

File tree

4 files changed

+7
-5
lines changed

4 files changed

+7
-5
lines changed

CHANGES.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ Fixed:
77
- user editing Role entry help text always appears
88
- disable forking server when os.fork() not available (sf bug 938586)
99
- removed Boolean from source to make py <2.3 happy (sf bug 938790)
10+
- fix nested scope bug in rdbms multilink sorting
11+
- re-seed the random number generator for each request
1012

1113

1214
2004-04-18 0.7.0b3

roundup/backends/back_mysql.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -698,7 +698,7 @@ def filter(self, search_matches, filterspec, sort=(None,None),
698698
r.append((id, m))
699699
i = 0
700700
for sortby in mlsort:
701-
def sortfun(a, b, dir=sortby[i]):
701+
def sortfun(a, b, dir=sortby[i], i=i):
702702
if dir == '-':
703703
return cmp(b[1][i], a[1][i])
704704
else:

roundup/backends/rdbms_common.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# $Id: rdbms_common.py,v 1.92 2004-04-20 05:47:33 richard Exp $
1+
# $Id: rdbms_common.py,v 1.93 2004-04-22 22:17:34 richard Exp $
22
''' Relational database (SQL) backend common code.
33
44
Basics:
@@ -2127,7 +2127,7 @@ def filter(self, search_matches, filterspec, sort=(None,None),
21272127
r.append((id, m))
21282128
i = 0
21292129
for sortby in mlsort:
2130-
def sortfun(a, b, dir=sortby[i]):
2130+
def sortfun(a, b, dir=sortby[i], i=i):
21312131
if dir == '-':
21322132
return cmp(b[1][i], a[1][i])
21332133
else:

tools/load_tracker.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#! /usr/bin/env python
2-
# $Id: load_tracker.py,v 1.2 2004-04-20 21:57:29 richard Exp $
2+
# $Id: load_tracker.py,v 1.3 2004-04-22 22:17:34 richard Exp $
33

44
'''
55
Usage: %s <tracker home> <N>
@@ -71,7 +71,7 @@
7171
priority=random.choice(priorities),
7272
status=random.choice(statuses),
7373
assignedto=random.choice(users))
74-
if i%100:
74+
if i%10:
7575
db.commit()
7676
print
7777

0 commit comments

Comments
 (0)