Skip to content

Commit 66f3ecf

Browse files
committed
Python 3 preparation: avoid basestring.
1 parent e670a3d commit 66f3ecf

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

roundup/cgi/templating.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1859,7 +1859,7 @@ def now(self, str_interval=None):
18591859

18601860
ret = date.Date('.', translator=self._client)
18611861

1862-
if isinstance(str_interval, basestring):
1862+
if is_us(str_interval):
18631863
sign = 1
18641864
if str_interval[0] == '-':
18651865
sign = -1
@@ -1896,7 +1896,7 @@ def field(self, size=30, default=None, format=_marker, popcal=True,
18961896
if default is None:
18971897
raw_value = None
18981898
else:
1899-
if isinstance(default, basestring):
1899+
if is_us(default):
19001900
raw_value = date.Date(default, translator=self._client)
19011901
elif isinstance(default, date.Date):
19021902
raw_value = default
@@ -2874,7 +2874,7 @@ def indexargs_url(self, url, args):
28742874
"""
28752875
q = urllib_.quote
28762876
sc = self.special_char
2877-
l = ['%s=%s'%(k,isinstance(v, basestring) and q(v) or v)
2877+
l = ['%s=%s'%(k,is_us(v) and q(v) or v)
28782878
for k,v in args.items() if v != None ]
28792879
# pull out the special values (prefixed by @ or :)
28802880
specials = {}

roundup/date.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ def cmp(a, b):
3838
return (a > b) - (a < b)
3939

4040
from roundup import i18n
41+
from roundup.anypy.strings import is_us
4142

4243
# no, I don't know why we must anchor the date RE when we only ever use it
4344
# in a match()
@@ -765,7 +766,7 @@ def __init__(self, spec, sign=1, allowdate=1, add_granularity=False,
765766
arith_types = (int, float)
766767
if isinstance(spec, arith_types):
767768
self.from_seconds(spec)
768-
elif isinstance(spec, basestring):
769+
elif is_us(spec):
769770
self.set(spec, allowdate=allowdate, add_granularity=add_granularity)
770771
elif isinstance(spec, Interval):
771772
(self.sign, self.year, self.month, self.day, self.hour,

0 commit comments

Comments
 (0)