Generic class editor may now restore retired items (thanks Ralf Hemmecke)

Author: Richard Jones

CHANGES.txt

@@ -3,6 +3,9 @@ are given with the most recent entry first.
 
 2009-XX-XX 1.4.XX (rXXXX)
 
+Features:
+- Generic class editor may now restore retired items (thanks Ralf Hemmecke)
+
 Fixes:
 - More SSL fixes. SSL wants the underlying socket non-blocking. So we
   don't call socket.setdefaulttimeout in case of SSL. This apparently

doc/acknowledgements.txt

@@ -51,6 +51,7 @@ Charles Groves,
 Engelbert Gruber,
 Bruce Guenter,
 Tamás Gulácsi,
+Ralf Hemmecke,
 Juergen Hermann,
 Tobias Herp,
 Uwe Hoffmann,

roundup/cgi/actions.py

@@ -320,6 +320,11 @@ def handle(self):
                     raise exceptions.Unauthorised, self._(
                         'You do not have permission to create %(class)s'
                     ) % {'class': self.classname}
+            elif cl.hasnode(itemid) and cl.is_retired(itemid):
+                # If a CSV line just mentions an id and the corresponding
+                # item is retired, then the item is restored.
+                cl.restore(itemid)
+                continue
             else:
                 exists = 1
 

share/roundup/templates/classic/html/_generic.index.html

@@ -39,7 +39,8 @@
 
 <p class="form-help">
  Remove entries by deleting their line. Add new entries by appending
- them to the table - put an X in the id column.
+ them to the table - put an X in the id column. If you wish to restore a
+ removed item and you know its id then just put that id in the id column.
 </p>
 </tal:block>
 <form onSubmit="return submit_once()" method="POST"

share/roundup/templates/minimal/html/_generic.index.html

@@ -39,7 +39,8 @@
 
 <p class="form-help">
  Remove entries by deleting their line. Add new entries by appending
- them to the table - put an X in the id column.
+ them to the table - put an X in the id column. If you wish to restore a
+ removed item and you know its id then just put that id in the id column.
 </p>
 </tal:block>
 <form onSubmit="return submit_once()" method="POST"