fix: remove delay when using csv export actions.

The CSV file is written incrementally, so we can't determine the
Content-Length. When using HTTP/1.1, this causes a delay while the
browser waits for a timeout. Forcing the connection to close after
the CSV file is written removes the delay.

Ideally we should shift to chunked transfer encoding for these two
actions, but that is much more invasive and when posting a request for
CSV, it is unlikely that another request will be sent over the same
socket.

Author: rouilj

CHANGES.txt

@@ -177,6 +177,11 @@ Fixed:
 - Cleanup tracker index generation by roundup-server. Send
   correct Content-Length headers so HTTP/1.1 connections don't
   hang. (John Rouillard)
+- Fix delay when using csv export actions. The CSV file is written
+  incrementally, so we can't determine the Content-Length. When using
+  HTTP/1.1, this causes a delay while the browser waits for a timeout.
+  Forcing the connection to close after the CSV file is written
+  removes the delay. (John Rouillard)
 
 Features:
 

roundup/cgi/actions.py

@@ -1724,6 +1724,11 @@ def fct(arg):
                     repr_function = represent[name]
                 row.append(repr_function(klass.get(itemid, name)))
             self.client._socket_op(writer.writerow, row)
+
+        # force close of connection since we can't send a
+        # Content-Length header.
+        self.client.request.close_connection = True
+
         return '\n'
 
 
@@ -1836,6 +1841,10 @@ def handle(self):
                 row.append(str(value))
             self.client._socket_op(writer.writerow, row)
 
+        # force close of connection since we can't send a
+        # Content-Length header.
+        self.client.request.close_connection = True
+
         return '\n'