Skip to content

Commit 5c1532b

Browse files
committed
fix: correct strings with multiple %s that can't be translated
Changed to use %(name)s for each element. make in the locale directory is no longer grousing.
1 parent 47f7c4e commit 5c1532b

File tree

1 file changed

+25
-19
lines changed

1 file changed

+25
-19
lines changed

roundup/rest.py

Lines changed: 25 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -2277,15 +2277,17 @@ def determine_output_format(self, uri):
22772277
if ext_type and (len(ext_type) < MAX_MIME_EXTENSION_LENGTH):
22782278
if ext_type not in list(self.__accepted_content_type.values()):
22792279
self.client.response_code = 406
2280-
return (None, uri,
2281-
self.error_obj(
2282-
406,
2283-
_("Content type '%s' requested in URL is "
2284-
"not available.\nAcceptable types: %s\n") %
2285-
(ext_type,
2286-
", ".join(sorted(
2287-
set(self.__accepted_content_type.values()))))))
2288-
2280+
return (
2281+
None, uri,
2282+
self.error_obj(
2283+
406,
2284+
_("Content type '%(requested)s' requested in URL is"
2285+
"not available.\nAcceptable types: "
2286+
"%(acceptable)s\n") %
2287+
{ "requested": ext_type,
2288+
"acceptable": ", ".join(sorted(
2289+
set(self.__accepted_content_type.values())))}))
2290+
22892291
# strip extension so uri makes sense.
22902292
# E.G. .../issue.json -> .../issue
22912293
uri = uri[:-(len(ext_type) + 1)]
@@ -2408,20 +2410,24 @@ def determine_output_format(self, uri):
24082410
return (None, uri,
24092411
self.error_obj(
24102412
406,
2411-
_("Requested content type(s) '%s' not available.\n"
2412-
"Acceptable mime types are: */*, %s") %
2413-
(self.client.request.headers.get('Accept'),
2414-
", ".join(sorted(
2415-
valid_binary_content_types)))))
2413+
_("Requested content type(s) '%(requested)s' not "
2414+
"available.\nAcceptable mime types are: */*, "
2415+
"%(acceptable)s") %
2416+
{"requested":
2417+
self.client.request.headers.get('Accept'),
2418+
"acceptable": ", ".join(sorted(
2419+
valid_binary_content_types))}))
24162420

24172421
return (None, uri,
24182422
self.error_obj(
24192423
406,
2420-
_("Requested content type(s) '%s' not available.\n"
2421-
"Acceptable mime types are: */*, %s") %
2422-
(self.client.request.headers.get('Accept'),
2423-
", ".join(sorted(
2424-
self.__accepted_content_type.keys())))))
2424+
_("Requested content type(s) '%(requested)s' not "
2425+
"available.\nAcceptable mime types are: */*, "
2426+
"%(acceptable)s") %
2427+
{"requested":
2428+
self.client.request.headers.get('Accept'),
2429+
"acceptable": ", ".join(sorted(
2430+
self.__accepted_content_type.keys()))}))
24252431

24262432
def dispatch(self, method, uri, input_payload):
24272433
"""format and process the request"""

0 commit comments

Comments
 (0)