Test self.db.db_version_updated in schema upgrade paths

A user on the roundup-users mailing list reported that a
'roundup-admin migrate' reported that changes were needed. But it
should have done the migration.

roundup-admin uses the property db.db_version_updated to tell if there
was a migration. Testing never looked at that property. Add a test for
that property in all migration updates.

AFAICT the test is always successful. So no bug uncovered by these
tests.

Author: rouilj

test/db_test_base.py

@@ -290,6 +290,8 @@ def testUpgrade_5_to_6(self):
             # test upgrade adding index
             self.db.post_init()
 
+            self.assertEqual(self.db.db_version_updated, True)
+
             # they're back
             self.db.sql('show indexes from _user;')
             self.assertEqual(5,len(self.db.cursor.fetchall()))

test/test_mysql.py

@@ -112,6 +112,8 @@ def testUpgrade_6_to_7(self):
         # test upgrade altering row
         self.db.post_init()
 
+        self.assertEqual(self.db.db_version_updated, True)
+
         # This insert with text of expected column size should succeed
         self.db.sql("insert into __words VALUES('%s',1)" % long_string)
 
@@ -165,6 +167,8 @@ def testUpgrade_7_to_8(self):
         # test upgrade
         self.db.post_init()
 
+        self.assertEqual(self.db.db_version_updated, True)
+
         # verify they keep all signifcant digits before the decimal point
         for tablename in ['otk', 'session']:
             self.db.sql(

test/test_postgresql.py

@@ -143,6 +143,8 @@ def testUpgrade_6_to_7(self):
         # test upgrade path
         self.db.post_init()
 
+        self.assertEqual(self.db.db_version_updated, True)
+
         # This insert with text of expected column size should succeed
         self.db.sql("insert into __words VALUES('%s',1)" % long_string)
 
@@ -204,6 +206,8 @@ def testUpgrade_7_to_8(self):
         # test upgrade altering row
         self.db.post_init()
 
+        self.assertEqual(self.db.db_version_updated, True)
+
         # verify they keep all signifcant digits before the decimal point
         for tablename in ['otk', 'session']:
             self.db.sql(

test/test_sqlite.py

@@ -108,6 +108,8 @@ def testUpgrade_6_to_7(self):
         # test upgrade adding __fts table
         self.db.post_init()
 
+        self.assertEqual(self.db.db_version_updated, True)
+
         # select should now work.
         self.db.sql("select * from __fts")
 
@@ -160,6 +162,8 @@ def testUpgrade_7_to_8(self):
         # test upgrade altering row
         self.db.post_init()
 
+        self.assertEqual(self.db.db_version_updated, True)
+
         # verify they keep all signifcant digits before the decimal point
         for tablename in ['otk', 'session']:
             Bdb = handle[tablename]