Skip to content

Commit 58cc1b6

Browse files
committed
build: prevent justhtml install < 3.10 python
The package says 3.10 or newer but does install on 3.8 (and maybe 3.9) but the formatting is different (it's actually more like beautifulsoup and dehtml output). So rather than trying to fix the test when it shouldn't be installed anyway just stop install if < 3.10.
1 parent 62661ed commit 58cc1b6

File tree

3 files changed

+11
-7
lines changed

3 files changed

+11
-7
lines changed

.github/workflows/ci-test.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -257,8 +257,11 @@ jobs:
257257
run: |
258258
set -xv
259259
pip install zstd || true
260-
# justhtml supports python 3.10 or newer.
261-
pip install justhtml || true
260+
# justhtml supports python 3.10 or newer according to pypi
261+
# page, but will install on 3.8 (and maybe 3.9) but formats
262+
# differently. So skip install if before 3.10.
263+
if echo $PYTHON_VERSION | grep '^3\...'; then
264+
pip install justhtml || true; fi
262265
if [[ "$PYTHON_VERSION" != "2."* ]]; then
263266
pip install Markdown; fi
264267

CHANGES.txt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,11 @@ Features:
6464
config.ini. (John Rouillard)
6565
- issue2551152 - added basic PGP setup/use info to admin_guide. (John
6666
Rouillard)
67-
- add support for the 'justhtml' html 5 parser library. It is written
68-
in pure Python. Used to convert html emails into plain text. Faster
69-
then beautifulsoup4 and it passes the html 5 standard browser test
70-
suite. Beautifulsoup is still supported. (John Rouillard)
67+
- add support for the 'justhtml' html 5 parser library for python >=
68+
3.10. It is written in pure Python. Used to convert html emails into
69+
plain text. Faster then beautifulsoup4 and it passes the html 5
70+
standard browser test suite. Beautifulsoup is still supported. (John
71+
Rouillard)
7172

7273
2025-07-13 2.5.0
7374

doc/installation.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -317,7 +317,7 @@ beautifulsoup, justhtml
317317
email into plain text, beautifulsoup4_ or justhtml_ can also be
318318
used. You can choose the converter in the tracker's
319319
config. Note that justhtml is pure Python, fast and conforms to
320-
HTML 5 standards.
320+
HTML 5 standards but works only for Python 3.10 or newer.
321321

322322
pywin32 - Windows Service
323323
You can run Roundup as a Windows service if pywin32_ is installed.

0 commit comments

Comments
 (0)