Try to fix:

  DeprecationWarning: invalid escape sequence \d
  DeprecationWarning: invalid escape sequence \s
  DeprecationWarning: invalid escape sequence \)

Strings under python 3 are unicode strings rather then "regular"
strings as under python 2. So all regexps need to be raw strings.
We will see how many I fixed and if I broke any.

Author: rouilj

roundup/backends/back_anydbm.py

@@ -919,7 +919,7 @@ def create_inner(self, **propvalues):
         newid = self.db.newid(self.classname)
 
         # validate propvalues
-        num_re = re.compile('^\d+$')
+        num_re = re.compile(r'^\d+$')
         for key, value in propvalues.items():
             if key == self.key:
                 try:
@@ -1094,7 +1094,7 @@ def get(self, nodeid, propname, default=_marker, cache=1):
                 raise ValueError('Journalling is disabled for this class')
             journal = self.db.getjournal(self.classname, nodeid)
             if journal:
-                num_re = re.compile('^\d+$')
+                num_re = re.compile(r'^\d+$')
                 value = journal[0][2]
                 if num_re.match(value):
                     return value
@@ -1114,7 +1114,7 @@ def get(self, nodeid, propname, default=_marker, cache=1):
                 raise ValueError('Journalling is disabled for this class')
             journal = self.db.getjournal(self.classname, nodeid)
             if journal:
-                num_re = re.compile('^\d+$')
+                num_re = re.compile(r'^\d+$')
                 value = journal[-1][2]
                 if num_re.match(value):
                     return value
@@ -1203,7 +1203,7 @@ def set_inner(self, nodeid, **propvalues):
         node = self.db.getnode(self.classname, nodeid)
         if self.db.RETIRED_FLAG in node:
             raise IndexError
-        num_re = re.compile('^\d+$')
+        num_re = re.compile(r'^\d+$')
 
         # if the journal value is to be different, store it in here
         journalvalues = {}
@@ -1690,7 +1690,7 @@ def getnodeids(self, db=None, retired=None):
         return res
 
     def _filter(self, search_matches, filterspec, proptree,
-            num_re = re.compile('^\d+$'), retired=False):
+            num_re = re.compile(r'^\d+$'), retired=False):
         """Return a list of the ids of the nodes in this class that
         match the 'filter' spec, sorted by the group spec and then the
         sort spec.

roundup/backends/rdbms_common.py

@@ -1572,7 +1572,7 @@ def create_inner(self, **propvalues):
         newid = self.db.newid(self.classname)
 
         # validate propvalues
-        num_re = re.compile('^\d+$')
+        num_re = re.compile(r'^\d+$')
         for key, value in propvalues.items():
             if key == self.key:
                 try:
@@ -1800,7 +1800,7 @@ def set_inner(self, nodeid, **propvalues):
         node = self.db.getnode(self.classname, nodeid)
         if self.is_retired(nodeid):
             raise IndexError('Requested item is retired')
-        num_re = re.compile('^\d+$')
+        num_re = re.compile(r'^\d+$')
 
         # make a copy of the values dictionary - we'll modify the contents
         propvalues = propvalues.copy()

roundup/cgi/TAL/HTMLParser.py

@@ -43,8 +43,8 @@
    )*
   \s*                                # trailing whitespace
 """, re.VERBOSE)
-endendtag = re.compile('>')
-endtagfind = re.compile('</\s*([a-zA-Z][-.a-zA-Z0-9:_]*)\s*>')
+endendtag = re.compile(r'>')
+endtagfind = re.compile(r'</\s*([a-zA-Z][-.a-zA-Z0-9:_]*)\s*>')
 
 
 class HTMLParseError(BaseException):

roundup/cgi/TAL/TALGenerator.py

@@ -305,7 +305,7 @@ def emitCondition(self, expr):
         self.emit("condition", cexpr, program)
 
     def emitRepeat(self, arg):
-        m = re.match("(?s)\s*(%s)\s+(.*)\Z" % NAME_RE, arg)
+        m = re.match(r"(?s)\s*(%s)\s+(.*)\Z" % NAME_RE, arg)
         if not m:
             raise TALError("invalid repeat syntax: " + repr(arg),
                            self.position)

roundup/cgi/accept_language.py

@@ -31,7 +31,7 @@
 # regexp for languange-range search
 nqlre = "([A-Za-z]+[-[A-Za-z]+]*)$"
 # regexp for languange-range search with quality value
-qlre  = "([A-Za-z]+[-[A-Za-z]+]*);q=([\d\.]+)"
+qlre  = r"([A-Za-z]+[-[A-Za-z]+]*);q=([\d\.]+)"
 # both
 lre   = re.compile(nqlre + "|" + qlre)
 

roundup/cgi/form_parser.py

@@ -41,7 +41,7 @@ def __init__(self, client):
             self._ = self.gettext = _translator.gettext
             self.ngettext = _translator.ngettext
 
-    def parse(self, create=0, num_re=re.compile('^\d+$')):
+    def parse(self, create=0, num_re=re.compile(r'^\d+$')):
         """ Item properties and their values are edited with html FORM
             variables and their values. You can:
 

roundup/cgi/templating.py

@@ -376,7 +376,7 @@ def classes(self):
             m.append(HTMLClass(self._client, item))
         return m
 
-num_re = re.compile('^-?\d+$')
+num_re = re.compile(r'^-?\d+$')
 
 def lookupIds(db, prop, ids, fail_ok=0, num_re=num_re, do_lookup=True):
     """ "fail_ok" should be specified if we wish to pass through bad values
@@ -932,7 +932,7 @@ def journal(self, direction='descending'):
         # XXX do this
         return []
 
-    def history(self, direction='descending', dre=re.compile('^\d+$'),
+    def history(self, direction='descending', dre=re.compile(r'^\d+$'),
                 limit=None, showall=False ):
         """Create an html view of the journal for the item.
 

roundup/configuration.py

@@ -1132,15 +1132,15 @@ def str2value(self, value):
             "Update issue title if incoming subject of email is different.\n"
             "Setting this to \"no\" will ignore the title part of"
             " the subject\nof incoming email messages.\n"),
-        (RegExpOption, "refwd_re", "(\s*\W?\s*(fw|fwd|re|aw|sv|ang)\W)+",
+        (RegExpOption, "refwd_re", r"(\s*\W?\s*(fw|fwd|re|aw|sv|ang)\W)+",
             "Regular expression matching a single reply or forward\n"
             "prefix prepended by the mailer. This is explicitly\n"
             "stripped from the subject during parsing."),
         (RegExpOption, "origmsg_re",
-            "^[>|\s]*-----\s?Original Message\s?-----$",
+            r"^[>|\s]*-----\s?Original Message\s?-----$",
             "Regular expression matching start of an original message\n"
             "if quoted the in body."),
-        (RegExpOption, "sign_re", "^[>|\s]*-- ?$",
+        (RegExpOption, "sign_re", r"^[>|\s]*-- ?$",
             "Regular expression matching the start of a signature\n"
             "in the message body."),
         (RegExpOption, "eol_re", r"[\r\n]+",

roundup/date.py

@@ -797,7 +797,7 @@ def __deepcopy__(self, memo):
         return Interval((self.sign, self.year, self.month, self.day,
             self.hour, self.minute, self.second), translator=self.translator)
 
-    def set(self, spec, allowdate=1, interval_re=re.compile('''
+    def set(self, spec, allowdate=1, interval_re=re.compile(r'''
             \s*(?P<s>[-+])?         # + or -
             \s*((?P<y>\d+\s*)y)?    # year
             \s*((?P<m>\d+\s*)m)?    # month

roundup/hyperdb.py

@@ -1570,7 +1570,7 @@ class HyperdbValueError(ValueError):
     """ Error converting a raw value into a Hyperdb value """
     pass
 
-def convertLinkValue(db, propname, prop, value, idre=re.compile('^\d+$')):
+def convertLinkValue(db, propname, prop, value, idre=re.compile(r'^\d+$')):
     """ Convert the link value (may be id or key value) to an id value. """
     linkcl = db.classes[prop.classname]
     if not idre or not idre.match(value):