Skip to content

Commit 519b689

Browse files
author
Richard Jones
committed
merge from HEAD
1 parent e78ae56 commit 519b689

File tree

4 files changed

+21
-17
lines changed

4 files changed

+21
-17
lines changed

CHANGES.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@ Fixed:
1010
- fixed documentation of filter() in the case of multiple values in a
1111
String search (sf bug 1373396)
1212
- fix comma-separated ID filter spec in web requests (sf bug 1396278)
13+
- fix Date: header generation to be LOCALE-agnostic (sf bug 1352624)
14+
- fix admin doc description of roundup-server config file
15+
- fix redirect after instant registration (sf bug 1381676)
1316

1417

1518
2005-10-07 0.8.5

doc/admin_guide.txt

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
Administration Guide
33
====================
44

5-
:Version: $Revision: 1.15.2.3 $
5+
:Version: $Revision: 1.15.2.4 $
66

77
.. contents::
88

@@ -73,7 +73,7 @@ Configuring roundup-server
7373
The basic configuration file layout is as follows (take from the
7474
``roundup-server.ini.example`` file in the "doc" directory)::
7575

76-
[server]
76+
[main]
7777
port = 8080
7878
;hostname =
7979
;user =
@@ -82,9 +82,9 @@ The basic configuration file layout is as follows (take from the
8282
;pidfile =
8383
;logfile =
8484

85+
[trackers]
8586
; Add one of these per tracker being served
86-
[tracker_url_component]
87-
home = /path/to/tracker
87+
name = /path/to/tracker/name
8888

8989
Values ";commented out" are optional. The meaning of the various options
9090
are as follows:
@@ -108,13 +108,10 @@ are as follows:
108108
written to this file. It must be specified if **pidfile** is specified.
109109
If per-tracker logging is specified, then very little will be written to
110110
this file.
111-
**example_tracker** sections
112-
These are used to specify which Roundup trackers are to be served up by
113-
roundup-server. Each tracker has its own ``[section]`` with a single
114-
``home`` value defined pointing to the tracker's home. The section name is
115-
used in the URL to select the appropriate reacker. Make sure the name part
116-
doesn't include any url-unsafe characters like spaces. Stick to
117-
alphanumeric characters and you'll be ok.
111+
**trackers** section
112+
Each line denotes a mapping from a URL component to a tracker home.
113+
Make sure the name part doesn't include any url-unsafe characters like
114+
spaces. Stick to alphanumeric characters and you'll be ok.
118115

119116

120117
Users and Security

roundup/cgi/actions.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#$Id: actions.py,v 1.40.2.8 2005-07-07 06:44:35 richard Exp $
1+
#$Id: actions.py,v 1.40.2.9 2006-01-13 03:34:34 richard Exp $
22

33
import re, cgi, StringIO, urllib, Cookie, time, random, csv
44

@@ -788,8 +788,7 @@ def handle(self):
788788

789789
# finish off by logging the user in
790790
self.userid = self.nodeid
791-
self.finishRego()
792-
return
791+
return self.finishRego()
793792

794793
# generate the one-time-key and store the props for later
795794
for propname, proptype in self.db.user.getprops().items():

roundup/mailer.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
"""Sending Roundup-specific mail over SMTP.
22
"""
33
__docformat__ = 'restructuredtext'
4-
# $Id: mailer.py,v 1.10 2004-07-25 15:25:44 a1s Exp $
4+
# $Id: mailer.py,v 1.10.2.1 2006-01-13 03:34:34 richard Exp $
55

66
import time, quopri, os, socket, smtplib, re
77

@@ -11,6 +11,12 @@
1111
from roundup.rfc2822 import encode_header
1212
from roundup import __version__
1313

14+
try:
15+
from email.Utils import formatdate
16+
except ImportError:
17+
def formatdate(timeval):
18+
return time.strftime("%a, %d %b %Y %H:%M:%S +0000", timeval)
19+
1420
class MessageSendError(RuntimeError):
1521
pass
1622

@@ -54,8 +60,7 @@ def get_standard_message(self, to, subject, author=None):
5460
writer.addheader('Subject', encode_header(subject, charset))
5561
writer.addheader('To', ', '.join(to))
5662
writer.addheader('From', author)
57-
writer.addheader('Date', time.strftime("%a, %d %b %Y %H:%M:%S +0000",
58-
time.gmtime()))
63+
writer.addheader('Date', formatdate(time.gmtime()))
5964

6065
# Add a unique Roundup header to help filtering
6166
writer.addheader('X-Roundup-Name', encode_header(tracker_name,

0 commit comments

Comments
 (0)