fix error in link property lookups with numeric-alike key values

[SF#1424550]

Author: Alexander Smishlajev

CHANGES.txt

@@ -6,6 +6,7 @@ Fixed:
 - failure with browsers not sending "Accept-Language" header (sf bug 1429646)
 - translate class name in "required property not supplied" error message
   (sf bug 1429669)
+- error in link property lookups with numeric-alike key values (sf bug 1424550)
 
 
 2006-02-10 1.1.0

roundup/cgi/templating.py

@@ -368,15 +368,13 @@ def lookupIds(db, prop, ids, fail_ok=0, num_re=re.compile('^-?\d+$')):
     cl = db.getclass(prop.classname)
     l = []
     for entry in ids:
-        if num_re.match(entry):
-            l.append(entry)
-        else:
-            try:
-                l.append(cl.lookup(entry))
-            except (TypeError, KeyError):
-                if fail_ok:
-                    # pass through the bad value
-                    l.append(entry)
+        try:
+            l.append(cl.lookup(entry))
+        except (TypeError, KeyError):
+            # if fail_ok, ignore lookup error
+            # otherwise entry must be existing object id rather than key value
+            if fail_ok or num_re.match(entry):
+                l.append(entry)
     return l
 
 def lookupKeys(linkcl, key, ids, num_re=re.compile('^-?\d+$')):