Skip to content

Commit 50a84e1

Browse files
author
Ralf Schlatterbeck
committed
- fix mailgw list of methods
.-- use getattr so that a derived class will work too.
1 parent ebe82a6 commit 50a84e1

File tree

1 file changed

+19
-18
lines changed

1 file changed

+19
-18
lines changed

roundup/mailgw.py

Lines changed: 19 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1190,44 +1190,45 @@ def create_node(self):
11901190
# method returns something that evaluates to True.
11911191
method_list = [
11921192
# Filter out messages to ignore
1193-
(handle_ignore, False),
1193+
("handle_ignore", False),
11941194
# Check for usage/help requests
1195-
(handle_help, False),
1195+
("handle_help", False),
11961196
# Check if the subject line is valid
1197-
(check_subject, False),
1197+
("check_subject", False),
11981198
# get importants parts from subject
1199-
(parse_subject, False),
1199+
("parse_subject", False),
12001200
# check for registration OTK
1201-
(rego_confirm, True),
1201+
("rego_confirm", True),
12021202
# get the classname
1203-
(get_classname, False),
1203+
("get_classname", False),
12041204
# get the optional nodeid:
1205-
(get_nodeid, False),
1205+
("get_nodeid", False),
12061206
# Determine who the author is:
1207-
(get_author_id, False),
1207+
("get_author_id", False),
12081208
# allowed to edit or create this class?
1209-
(check_permissions, False),
1209+
("check_permissions", False),
12101210
# author may have been created:
12111211
# commit author to database and re-open as author
1212-
(commit_and_reopen_as_author, False),
1212+
("commit_and_reopen_as_author", False),
12131213
# Get the recipients list
1214-
(get_recipients, False),
1214+
("get_recipients", False),
12151215
# get the new/updated node props
1216-
(get_props, False),
1216+
("get_props", False),
12171217
# Handle PGP signed or encrypted messages
1218-
(get_pgp_message, False),
1218+
("get_pgp_message", False),
12191219
# extract content and attachments from message body:
1220-
(get_content_and_attachments, False),
1220+
("get_content_and_attachments", False),
12211221
# put attachments into files linked to the issue:
1222-
(create_files, False),
1222+
("create_files", False),
12231223
# create the message if there's a message body (content):
1224-
(create_msg, False),
1224+
("create_msg", False),
12251225
]
12261226

12271227

12281228
def parse (self):
1229-
for method, flag in self.method_list:
1230-
ret = method(self)
1229+
for methodname, flag in self.method_list:
1230+
method = getattr (self, methodname)
1231+
ret = method()
12311232
if flag and ret:
12321233
return
12331234
# perform the node change / create:

0 commit comments

Comments
 (0)