code cleanup (patch [SF#115329] and additional)

Author: Richard Jones

CHANGES.txt

@@ -12,6 +12,7 @@ Fixed:
 - more documentation of security mechanisms (incl. sf patches 1117932,
   1117860)
 - better unit tests for security mechanisms
+- code cleanup (sf patch 1115329 and additional)
 
 
 2005-01-13 0.8.0b2

roundup/roundupdb.py

@@ -15,7 +15,7 @@
 # BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE,
 # SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
 #
-# $Id: roundupdb.py,v 1.117 2004-11-12 04:07:03 richard Exp $
+# $Id: roundupdb.py,v 1.118 2005-02-12 00:57:08 richard Exp $
 
 """Extending hyperdb with types specific to issue-tracking.
 """
@@ -433,9 +433,9 @@ def generateCreateNote(self, nodeid):
 
         # list the values
         m = []
-        l = props.items()
-        l.sort()
-        for propname, prop in l:
+        prop_items = props.items()
+        prop_items.sort()
+        for propname, prop in prop_items:
             value = cl.get(nodeid, propname, None)
             # skip boring entries
             if not value:
@@ -500,9 +500,9 @@ def generateChangeNote(self, nodeid, oldvalues):
 
         # list the changes
         m = []
-        l = changed.items()
-        l.sort()
-        for propname, oldvalue in l:
+        changed_items = changed.items()
+        changed_items.sort()
+        for propname, oldvalue in changed_items:
             prop = props[propname]
             value = cl.get(nodeid, propname, None)
             if isinstance(prop, hyperdb.Link):