Skip to content

Commit 4ed123a

Browse files
committed
Fix microcopy for CSRF validation failure. Remove display of bad
token, I mean what is the user going to do with it. Details are logged so no info is lost. Make verbage more user friendly. Suggest re-entering unsaved data and trying again.
1 parent 7686b83 commit 4ed123a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

roundup/cgi/client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1304,7 +1304,7 @@ def handle_csrf(self, xmlrpc=False):
13041304
logger.error(
13051305
self._("Csrf mismatch user: current user %s != stored user %s, current session, stored session: %s,%s for key %s."),
13061306
current_user, nonce_user, current_session, nonce_session, key)
1307-
raise UsageError(self._("Invalid csrf token found: %s")%key)
1307+
raise UsageError(self._("We can't validate your session (csrf failure). Re-enter any unsaved data and try again."))
13081308
elif enforce == 'logfailure':
13091309
logger.warning(
13101310
self._("logged only: Csrf mismatch user: current user %s != stored user %s, current session, stored session: %s,%s for key %s."),
@@ -1314,7 +1314,7 @@ def handle_csrf(self, xmlrpc=False):
13141314
logger.error(
13151315
self._("Csrf mismatch user: current session %s != stored session %s, current user/stored user is: %s for key %s."),
13161316
current_session, nonce_session, current_user, key)
1317-
raise UsageError(self._("Invalid csrf session found: %s")%key)
1317+
raise UsageError(self._("We can't validate your session (csrf failure). Re-enter any unsaved data and try again."))
13181318
elif enforce == 'logfailure':
13191319
logger.warning(
13201320
self._("logged only: Csrf mismatch user: current session %s != stored session %s, current user/stored user is: %s for key %s."),

0 commit comments

Comments
 (0)