allow binary data for "content" props through rawToHyperdb

Author: Richard Jones

CHANGES.txt

@@ -20,6 +20,7 @@ Fixed:
 - Session API and cleanup thanks anatoly t.
 - Make WSGI handler threadsafe (sf #1968027)
 - Improved URL matching RE (sf #2038858)
+- Allow binary file content submission via XML-RPC (sf #1995623)
 
 
 2008-03-01 1.4.4

roundup/hyperdb.py

@@ -15,7 +15,7 @@
 # BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE,
 # SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
 #
-# $Id: hyperdb.py,v 1.131 2007-09-27 06:18:53 jpend Exp $
+# $Id: hyperdb.py,v 1.132 2008-08-18 06:21:53 richard Exp $
 
 """Hyperdatabase implementation, especially field types.
 """
@@ -53,8 +53,12 @@ class String(_Type):
     def __init__(self, indexme='no', required=False):
         super(String, self).__init__(required)
         self.indexme = indexme == 'yes'
-    def from_raw(self, value, **kw):
+    def from_raw(self, value, propname='', **kw):
         """fix the CRLF/CR -> LF stuff"""
+        if propname == 'content':
+            # Why oh why wasn't the FileClass content property a File
+            # type from the beginning?
+            return value
         return fixNewlines(value)
     def sort_repr (self, cls, val, name):
         if not val:

test/test_xmlrpc.py

@@ -69,6 +69,12 @@ def testCreate(self):
         results = self.server.display('joe', 'random', issueid, 'title')
         self.assertEqual(results['title'], 'foo')
 
+    def testFileCreate(self):
+        results = self.server.create('joe', 'random', 'file', 'content=hello\r\nthere')
+        fileid = 'file' + results
+        results = self.server.display('joe', 'random', fileid, 'content')
+        self.assertEqual(results['content'], 'hello\r\nthere')
+
     def testAuthUnknown(self):
         # Unknown user (caught in XMLRPC frontend).
         self.assertRaises(Unauthorised, self.server.list,