chore: optimize build file make it error sooner on flake8 tests

Move:

  pip update,
  pip install of required python test modules (pytest, flake8 ...)
  flake8 sanity test

before all the code that sets installs xapian, whoosh, databases etc.

This should make a syntax error creeping in fail faster.

Author: rouilj

.github/workflows/ci-test.yml

@@ -113,6 +113,21 @@ jobs:
           python -c "import sqlite3; print('sqlite version: ', sqlite3.sqlite_version)"
           python -c "import setuptools; print('setuptools version: ', setuptools.__version__);"
 
+      - name: Update pip
+        run: python -m pip install --upgrade pip
+
+      - name: Install pytest and other packages needed for running tests
+        run: pip install flake8 mock pytest pytest-cov requests sphinx-tabs
+
+      - name: run flake8 - abort for syntax error, otherwise warn only
+        run: |
+            # stop the build for Python syntax errors or undefined names
+            # talgettext is a utility function ignore it.
+            flake8 roundup --count --select=E9,F63,F7,F82 --show-source --statistics --extend-exclude talgettext.py
+            # exit-zero treats all errors as warnings.
+            #   The GitHub editor is 127 chars wide
+            flake8 roundup --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
+
       # Install the databases
       - name: Install mysql/mariadb
         run: |
@@ -162,9 +177,6 @@ jobs:
           sudo apt-get install redis
           pip install redis
 
-      - name: Update pip
-        run: python -m pip install --upgrade pip
-
       - name: Install python db libraries
         run: pip install psycopg2 mysqlclient
 
@@ -218,24 +230,12 @@ jobs:
           fi
           case "$PYTHON_VERSION" in nightly) echo skipping xapian build;; *) make && sudo make install; esac
 
-      - name: Install pytest and other packages needed for running tests
-        run: pip install flake8 mock pytest pytest-cov requests sphinx-tabs
-
       - name: Test build roundup and install locale so lang tests work.
         run: |
           sudo apt-get install gettext
           python setup.py build
           (cd locale; make local_install; ls -lR locale/de/LC_MESSAGES)
 
-      - name: run flake8 - abort for syntax error, otherwise warn only
-        run: |
-            # stop the build for Python syntax errors or undefined names
-            # talgettext is a utility function ignore it.
-            flake8 roundup --count --select=E9,F63,F7,F82 --show-source --statistics --extend-exclude talgettext.py
-            # exit-zero treats all errors as warnings.
-            #   The GitHub editor is 127 chars wide
-            flake8 roundup --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
-
       # Run the tests using pytest with test files in tests directory.
       - name: Run tests
         run: |