Skip to content

Commit 49c5aad

Browse files
author
Ralf Schlatterbeck
committed
Fix setting of sys.path when importing schema.py, fixes issue2550675,
thanks to Bryce L Nordgren for reporting.
1 parent ee3a4dc commit 49c5aad

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

CHANGES.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ Fixed:
1919
see doc/upgrading.txt for how to fix your trackers! (Ralf Schlatterbeck).
2020
- Some minor typos fixed in doc/customizing.txt (Thanks Ralf Hemmecke).
2121
- XML-RPC documentation now linked from the docs/index (Bernhard Reiter).
22+
- Fix setting of sys.path when importing schema.py, fixes issue2550675,
23+
thanks to Bryce L Nordgren for reporting.
2224

2325
2010-10-08 1.4.16 (r4541)
2426

doc/acknowledgements.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ Ramiro Morales,
9494
Toni Mueller,
9595
Stefan Niederhauser,
9696
Truls E. Næss,
97+
Bryce L Nordgren,
9798
Patrick Ohly,
9899
Luke Opperman,
99100
Eddie Parker,

roundup/instance.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,9 @@ def open(self, name=None):
113113
'db': backend.Database(self.config, name)
114114
}
115115

116+
libdir = os.path.join(self.tracker_home, 'lib')
117+
if os.path.isdir(libdir):
118+
sys.path.insert(1, libdir)
116119
if self.optimize:
117120
# execute preloaded schema object
118121
exec(self.schema, vars)
@@ -121,9 +124,6 @@ def open(self, name=None):
121124
# use preloaded detectors
122125
detectors = self.detectors
123126
else:
124-
libdir = os.path.join(self.tracker_home, 'lib')
125-
if os.path.isdir(libdir):
126-
sys.path.insert(1, libdir)
127127
# execute the schema file
128128
self._load_python('schema.py', vars)
129129
if callable (self.schema_hook):
@@ -132,8 +132,8 @@ def open(self, name=None):
132132
for extension in self.get_extensions('extensions'):
133133
extension(self)
134134
detectors = self.get_extensions('detectors')
135-
if libdir in sys.path:
136-
sys.path.remove(libdir)
135+
if libdir in sys.path:
136+
sys.path.remove(libdir)
137137
db = vars['db']
138138
# apply the detectors
139139
for detector in detectors:

0 commit comments

Comments
 (0)