Fix issue2550505.

Author: stefanseefeld

roundup/backends/back_anydbm.py

@@ -1561,7 +1561,7 @@ def _filter(self, search_matches, filterspec, proptree,
         "sort" and "group" are (dir, prop) where dir is '+', '-' or None
         and prop is a prop name or None
 
-        "search_matches" is {nodeid: marker} or None
+        "search_matches" is a sequence type or None
 
         The filter must match all properties specificed. If the property
         value to match is a list:
@@ -1721,7 +1721,7 @@ def _filter(self, search_matches, filterspec, proptree,
             if search_matches is not None:
                 k = []
                 for v in matches:
-                    if search_matches.has_key(v[0]):
+                    if v[0] in search_matches:
                         k.append(v)
                 matches = k
 

roundup/backends/rdbms_common.py

@@ -2114,7 +2114,7 @@ def filter(self, search_matches, filterspec, sort=[], group=[]):
         backward-compatibility reasons a single (dir, prop) tuple is
         also allowed.
 
-        "search_matches" is {nodeid: marker} or None
+        "search_matches" is a sequence type or None
 
         The filter must match all properties specificed. If the property
         value to match is a list:
@@ -2123,7 +2123,7 @@ def filter(self, search_matches, filterspec, sort=[], group=[]):
         2. Other properties must match any of the elements in the list.
         """
         # we can't match anything if search_matches is empty
-        if search_matches == {}:
+        if not search_matches and search_matches is not None:
             return []
 
         if __debug__:
@@ -2334,8 +2334,7 @@ def filter(self, search_matches, filterspec, sort=[], group=[]):
 
         # add results of full text search
         if search_matches is not None:
-            v = search_matches.keys()
-            s = ','.join([a for x in v])
+            s = ','.join([a for x in search_matches])
             where.append('_%s.id in (%s)'%(icn, s))
             args = args + v
 

roundup/hyperdb.py

@@ -707,7 +707,7 @@ def storefile(self, classname, nodeid, property, content):
         raise NotImplementedError
 
     def getfile(self, classname, nodeid, property):
-        '''Store the content of the file in the database.
+        '''Get the content of the file in the database.
         '''
         raise NotImplementedError
 
@@ -1129,7 +1129,7 @@ def filter(self, search_matches, filterspec, sort=[], group=[]):
         backward-compatibility reasons a single (dir, prop) tuple is
         also allowed.
 
-        "search_matches" is {nodeid: marker}
+        "search_matches" is a sequence type
 
         The filter must match all properties specificed. If the property
         value to match is a list: