Fix scripts/roundup-reminder for Python 3 (issue 2550978).

Stop using MimeWriter.  Also, the previous replacement of cmp= with
key= for a comparison didn't actually work (dates, which can't be
negated, were being compared, not integers), so use a class to deal
with reversing date order for comparisons.

Author: jsm28

scripts/roundup-reminder

@@ -28,10 +28,11 @@ TODO: possibly make this more general and configurable...
 '''
 
 from __future__ import print_function
-import sys, MimeWriter, smtplib
+import sys
+from email.mime.multipart import MIMEMultipart
+from email.utils import make_msgid
 from roundup import instance, date
-from roundup.mailer import SMTPConnection
-from roundup.anypy.strings import StringIO
+from roundup.mailer import Mailer
 
 # open the instance
 if len(sys.argv) != 2:
@@ -42,9 +43,28 @@ db = instance.open('admin')
 
 resolved_id = db.status.lookup('resolved')
 
+class Reverse:
+    """Class reversing sort order."""
+
+    def __init__(self, val):
+        self.val = val
+
+    def __lt__(self, other):
+        return other.val < self.val
+    def __le__(self, other):
+        return other.val <= self.val
+    def __eq__(self, other):
+        return other.val == self.val
+    def __ne__(self, other):
+        return other.val != self.val
+    def __gt__(self, other):
+        return other.val > self.val
+    def __ge__(self, other):
+        return other.val >= self.val
+
 def listKey(x):
     "key for tuples such that order is positive on [0] and negative on [1]"
-    return (x[0], -x[1])
+    return (x[0], Reverse(x[1]))
     return 0
 
 # loop through all the users
@@ -72,88 +92,86 @@ for user_id in db.user.list():
         continue
 
     # generate the email message
-    message = StringIO()
-    writer = MimeWriter.MimeWriter(message)
-    writer.addheader('Subject', 'Your active %s issues'%db.config.TRACKER_NAME)
-    writer.addheader('To', address)
-    writer.addheader('From', '%s <%s>'%(db.config.TRACKER_NAME,
-        db.config.ADMIN_EMAIL))
-    writer.addheader('Reply-To', '%s <%s>'%(db.config.TRACKER_NAME,
-        db.config.ADMIN_EMAIL))
-    writer.addheader('MIME-Version', '1.0')
-    writer.addheader('X-Roundup-Name', db.config.TRACKER_NAME)
-
-    # start the multipart
-    part = writer.startmultipartbody('alternative')
-    part = writer.nextpart()
-    body = part.startbody('text/plain')
-    
+    mailer = Mailer(db.config)
+    message = MIMEMultipart('alternative')
+    mailer.set_message_attributes(
+        message,
+        [address],
+        'Your active %s issues'%db.config.TRACKER_NAME)
+    message['Reply-To'] = '%s <%s>'%(db.config.TRACKER_NAME,
+                                     db.config.ADMIN_EMAIL)
+    message['Message-Id'] = make_msgid()
+
     # do the plain text bit
-    print('Created     ID   Activity  Title', file=body)
-    print('='*75, file=body)
+    text_lines = []
+    text_lines.append('Created     ID   Activity  Title')
+    text_lines.append('='*75)
     #             '2 months    213  immediate cc_daemon barfage
     old_priority = None
     for priority_order, activity_date, creation_date, issue_id in l:
         priority = db.issue.get(issue_id, 'priority')
         if (priority != old_priority):
             old_priority = priority
-            print('    ', db.priority.get(priority,'name'), file=body)
+            text_lines.append('     ' + db.priority.get(priority,'name'))
         # pretty creation
         creation = (creation_date - date.Date('.')).pretty()
         activity = (activity_date - date.Date('.')).pretty()
         title = db.issue.get(issue_id, 'title')
         if len(title) > 42:
             title = title[:38] + ' ...'
-        print('%-11s %-4s %-9s %-42s'%(creation, issue_id,
-            activity, title), file=body)
+        text_lines.append('%-11s %-4s %-9s %-42s'%(creation, issue_id,
+            activity, title))
 
     # some help to finish off
-    print('''
+    text_lines.append('''
 To view or respond to any of the issues listed above, visit the URL
 
    %s
 
 and click on "My Issues". Do NOT respond to this message.
-'''%db.config.TRACKER_WEB, file=body)
+'''%db.config.TRACKER_WEB)
+    text = '\n'.join(text_lines) + '\n'
+    part = mailer.get_text_message()
+    part.set_payload(text, part.get_charset())
+    message.attach(part)
 
 
     # now the HTML one
-    part = writer.nextpart()
-    body = part.startbody('text/html')
+    html_lines = []
     colours = {
         'immediate': ' bgcolor="#ffcdcd"',
         'day': ' bgcolor="#ffdecd"',
         'week': ' bgcolor="#ffeecd"',
         'month': ' bgcolor="#ffffcd"',
         'whenever': ' bgcolor="#ffffff"',
     }
-    print('''<table border>
+    html_lines.append('''<table border>
 <tr><th>Created</th> <th>ID</th> <th>Activity</th> <th>Title</th></tr>
-''', file=body)
+''')
     old_priority = None
     for priority_order, activity_date, creation_date, issue_id in l:
         priority = db.issue.get(issue_id,'priority')
         if (priority != old_priority):
            old_priority = priority
-           print('<tr><td>-></td><td>-></td><td>-></td><td><b>%s</b></td></tr>'%db.priority.get(priority,'name'), file=body)
+           html_lines.append('<tr><td>-></td><td>-></td><td>-></td><td><b>%s</b></td></tr>'%db.priority.get(priority,'name'))
         creation = (creation_date - date.Date('.')).pretty()
         title = db.issue.get(issue_id, 'title')
         issue_id = '<a href="%sissue%s">%s</a>'%(db.config.TRACKER_WEB,
             issue_id, issue_id)
         activity = (activity_date - date.Date('.')).pretty()
-        print('''<tr><td>%s</td><td>%s</td><td>%s</td>
-    <td>%s</td></tr>'''%(creation, issue_id, activity, title), file=body)
-    print('</table>', file=body)
+        html_lines.append('''<tr><td>%s</td><td>%s</td><td>%s</td>
+    <td>%s</td></tr>'''%(creation, issue_id, activity, title))
+    html_lines.append('</table>')
 
-    print('''<p>To view or respond to any of the issues listed
+    html_lines.append('''<p>To view or respond to any of the issues listed
         above, simply click on the issue ID. Do <b>not</b> respond to
-        this message.</p>''', file=body)
-
-    # finish of the multipart
-    writer.lastpart()
+        this message.</p>''')
+    html = '\n'.join(html_lines) + '\n'
+    part = mailer.get_text_message('utf-8', 'html')
+    part.set_payload(html, part.get_charset())
+    message.attach(part)
 
     # all done, send!
-    smtp = SMTPConnection(db.config)
-    smtp.sendmail(db.config.ADMIN_EMAIL, address, message.getvalue())
+    mailer.smtp_send([address], message.as_string())
 
 # vim: set filetype=python ts=4 sw=4 et si