Skip to content

Commit 4404243

Browse files
committed
fix: roundup_demo should use port assignment
There are three port values: urlport (-P) - used in the URL when docker maps real port to external port port (-p) - used to set port roundup listens on DEFAULT_PORT = 8917 used for -p if not set. Before the -p argument was not used if -P was not set. So you can override the default 8917.
1 parent a2ace3a commit 4404243

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

CHANGES.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,8 @@ Fixed:
133133
Rouillard)
134134
- issue2551285 - Remove StructuredText support. reStructuredText is
135135
still supported. (John Rouillard)
136+
- Use roundup-demo -p option to set listening port. Was ignored
137+
before. (John Rouillard)
136138

137139
Features:
138140

roundup/scripts/roundup_demo.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ def run():
170170
# install
171171
demo.install_demo(home, backend,
172172
admin.AdminTool().listTemplates()[template]['path'],
173-
use_port=cli_args.urlport or DEFAULT_PORT)
173+
use_port=cli_args.urlport or cli_args.port or DEFAULT_PORT)
174174
else:
175175
# make sure that no options are specified that are only useful on initialization.
176176
if ( cli_args.backend or cli_args.template or

0 commit comments

Comments
 (0)