I had an incorrect fix for issue2550601. Changed schema to define

class patches not patch.

Changed commented out patches section in bug.item.html to
use patches-1 an not patch-1 as a result of schema changes.

The show open Milestones link had a leak of the @group
value. If you clicked on show open tasks or show open bugs
they group by priority.

The url being formed for show open milestones was inheriting the @group
if you were on an index page for bugs or milestones. Explicit set the
@group to status (which a milestone does have) prevents the

@group=priority from being applied to a milestone index page which
results in a red error banner stating priority is an invalid param for
milestones.

./demo.py -t devel now runs without obvious breakage.

Author: rouilj

share/roundup/templates/devel/html/bug.item.html

@@ -176,21 +176,21 @@
 <tr tal:condition="context/is_edit_ok">
  <th><tal:block i18n:translate="">Patch</tal:block>:</th>
  <td colspan="3">
-   <input type="hidden" name="@link@patches" value="patch-1"/>
-   <input type="file" name="patch-1@content" size="35"/>
+   <input type="hidden" name="@link@patches" value="patches-1"/>
+   <input type="file" name="patches-1@content" size="35"/>
  </td>
 </tr>
 <tr tal:condition="context/is_edit_ok">
  <th><tal:block i18n:translate="">Patch Description</tal:block>:</th>
- <td colspan=3><input type="edit" name="patch-1@description" size="40"></td>
+ <td colspan=3><input type="edit" name="patches-1@description" size="40"></td>
 </tr>
 <tr tal:condition="context/is_edit_ok">
  <th><tal:block i18n:translate="">Repository</tal:block>:</th>
- <td colspan=3><input type="edit" name="patch-1@repository" size="40"></td>
+ <td colspan=3><input type="edit" name="patches-1@repository" size="40"></td>
 </tr>
 <tr tal:condition="context/is_edit_ok">
  <th><tal:block i18n:translate="">Repo. Revision</tal:block>:</th>
- <td colspan=3><input type="edit" name="patch-1@revision" size="40"></td>
+ <td colspan=3><input type="edit" name="patches-1@revision" size="40"></td>
 </tr>
 -->
 </table>
@@ -322,3 +322,4 @@
 </td>
 
 </tal:block>
+<!-- SHA: b8f7d44a12ed641c457adebd68b1e0eab5369e7c -->

share/roundup/templates/devel/html/page.html

@@ -144,6 +144,7 @@ <h1><a href="/">Roundup Demo Tracker</a></h1>
                                 'status': milestone_status_notclosed,
                                 '@dispname': i18n.gettext('Show Open'),
                                 '@startwith': 0,
+                                '@group': 'status',
                                 })"
                 i18n:translate="">Show Open</a>
        </li>
@@ -429,3 +430,4 @@ <h1 id="breadcrumb"><span metal:define-slot="body_title">body title</span></h1>
     <input metal:define-macro="user_confirm_input" type="password"
     tal:attributes="id name; name string:@confirm@$name; readonly not:edit_ok" value=""/>
 
+<!-- SHA: ca32e5f43efcb7c3b4940df6f7a176f6990b15f0 -->

share/roundup/templates/devel/schema.py

@@ -126,7 +126,7 @@
                 description=String(indexme='yes'))
 
 # Patch
-patch = FileClass(db, "patch",
+patches = FileClass(db, "patches",
                   name=String(),
                   description=String(indexme='yes'),
                   repository=String(),