format parameter for DateHTMLProperty.field() (based on patch [SF#1072834])

Author: Alexander Smishlajev

roundup/cgi/templating.py

@@ -1329,6 +1329,9 @@ def field(self):
         return s
 
 class DateHTMLProperty(HTMLProperty):
+
+    _marker = []
+
     def __init__(self, client, classname, nodeid, prop, name, value,
             anonymous=0, offset=None):
         HTMLProperty.__init__(self, client, classname, nodeid, prop, name,
@@ -1374,12 +1377,19 @@ def now(self, str_interval=None):
         return DateHTMLProperty(self._client, self._classname, self._nodeid,
             self._prop, self._formname, ret)
 
-    def field(self, size=30, default=None):
-        ''' Render a form edit field for the property
+    def field(self, size=30, default=None, format=_marker):
+        '''Render a form edit field for the property
 
-            If not editable, just display the value via plain().
+        If not editable, just display the value via plain().
+
+        The format string is a standard python strftime format string.
         '''
         self.view_check()
+        if not self.is_edit_ok():
+            if format is self._marker:
+                return self.plain()
+            else:
+                return self.pretty(format)
 
         if self._value is None:
             if default is None:
@@ -1401,16 +1411,18 @@ def field(self, size=30, default=None):
         if raw_value is None:
             value = ''
         elif type(raw_value) is type(''):
-            value = raw_value
+            if format is self._marker:
+                value = raw_value
+            else:
+                value = date.Date(raw_value).pretty(format)
         else:
             tz = self._db.getUserTimezone()
-            value = cgi.escape(str(raw_value.local(tz)))
+            value = raw_value.local(tz)
+            if format is not self._marker:
+                value = value.pretty(format)
 
-        if self.is_edit_ok():
-            value = '"'.join(value.split('"'))
-            return self.input(name=self._formname,value=value,size=size)
-
-        return self.plain()
+        value = cgi.escape(str(value), True)
+        return self.input(name=self._formname, value=value, size=size)
 
     def reldate(self, pretty=1):
         ''' Render the interval between the date and now.
@@ -1428,7 +1440,6 @@ def reldate(self, pretty=1):
             return interval.pretty()
         return str(interval)
 
-    _marker = []
     def pretty(self, format=_marker):
         ''' Render the date in a pretty format (eg. month names, spaces).
 
@@ -1439,7 +1450,9 @@ def pretty(self, format=_marker):
         '''
         self.view_check()
 
-        if format is not self._marker:
+        if not self._value:
+            return ''
+        elif format is not self._marker:
             return self._value.pretty(format)
         else:
             return self._value.pretty()