Skip to content

Commit 36530aa

Browse files
author
Richard Jones
committed
sorting of entries in classhelp popup [SF#1449000]
1 parent 4f81514 commit 36530aa

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

CHANGES.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ Fixed:
1919
- reduced frequency of session timestamp update
2020
- classhelp popup pagination forgot about "type" (sf bug 1465836)
2121
- umask is now configurable (with the same 0002 default)
22+
- sorting of entries in classhelp popup (sf bug 1449000)
2223

2324

2425
2006-03-03 1.1.1

roundup/cgi/templating.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -663,11 +663,10 @@ def classhelp(self, properties=None, label=''"(list)", width='500',
663663
properties = ','.join(properties)
664664
if sort is None:
665665
if 'username' in properties.split( ',' ):
666-
sort = '&@sort=username'
666+
sort = 'username'
667667
else:
668-
sort = ''
669-
else:
670-
sort = '&@sort=' + sort
668+
sort = find_sort_key(self._klass)
669+
sort = '&@sort=' + sort
671670
if property:
672671
property = '&property=%s'%property
673672
if form:

0 commit comments

Comments
 (0)