remember where we came from when logging in (patch [SF#1312889])

Author: Richard Jones

CHANGES.txt

@@ -8,6 +8,7 @@ Feature:
 - added Xapian indexer; replaces standard indexers if Xapian is available
 - mailgw subject parsing has configurable levels of strictness
 - nosy messages may be sent individually to all recipients
+- remember where we came from when logging in (sf patch 1312889)
 
 
 2005-10-07 0.8.5

roundup/cgi/actions.py

@@ -1,4 +1,4 @@
-#$Id: actions.py,v 1.48 2005-07-07 06:46:09 richard Exp $
+#$Id: actions.py,v 1.49 2005-10-07 04:49:48 richard Exp $
 
 import re, cgi, StringIO, urllib, Cookie, time, random, csv
 
@@ -888,6 +888,10 @@ def handle(self):
         # set the session cookie
         self.client.set_cookie(self.client.user)
 
+        # If we came from someplace, go back there
+        if self.form.has_key('__came_from'):
+            raise exceptions.Redirect, self.form['__came_from'].value
+
     def verifyLogin(self, username, password):
         # make sure the user exists
         try:

templates/classic/html/page.html

@@ -101,6 +101,7 @@ <h2><span metal:define-slot="body_title">body title</span></h2>
     <input size="10" type="password" name="__login_password"><br>
     <input type="hidden" name="@action" value="Login">
     <input type="submit" value="Login" i18n:attributes="value"><br>
+    <input type="hidden" name="__came_from" tal:attributes="value string:${request/base}${request/env/PATH_INFO}">
     <span tal:replace="structure request/indexargs_form" />
     <a href="user?@template=register"
        tal:condition="python:request.user.hasPermission('Create', 'user')"

templates/minimal/html/page.html

@@ -42,6 +42,7 @@ <h2><span metal:define-slot="body_title">body title</span></h2>
     <input size="10" type="password" name="__login_password"><br>
     <input type="hidden" name="@action" value="Login">
     <input type="submit" value="Login" i18n:attributes="value">
+    <input type="hidden" name="__came_from" tal:attributes="value string:${request/base}${request/env/PATH_INFO}">
     <span tal:replace="structure request/indexargs_form" />
    </form>
    <a tal:condition="python:request.user.hasPermission('Web Registration')"