*** empty log message ***

Author: Richard Jones

CHANGES.txt

@@ -34,8 +34,6 @@ Feature:
   Use this to specify server configuration file for the service.
 - added experimental multi-thread server
 - don't try to import all backends in backends.__init__ unless we *want* to
-- TAL expressions like 'request/show/whatever' return True
-  if the request does not contain explicit @columns list
 
 Fixed:
 - postgres backend open doesn't hide corruption in schema (sf bug 956375)
@@ -55,6 +53,8 @@ Fixed:
 - enforce View Permission when serving file content (sf bug 1050470)
 - don't index common words (sf bug 1046612)
 - don't wrap query.item.html in a <span> (thanks Roch'e Compaan)
+- TAL expressions like 'request/show/whatever' return True
+  if the request does not contain explicit @columns list
 - NumberHTMLProperty should return '' not "None" if not set (thanks
   William)
 - ensure multilink ordering in RDBMS backends (thanks Marcus Priesch, sf

doc/whatsnew-0.8.txt

@@ -28,6 +28,8 @@ To write extension code for Roundup you place a file in the tracker home
 information about how this is done.
 
 
+XXX Client.actions is now a dictionary.
+
 Added support for HTTP charset selection
 ========================================
 

roundup/cgi/client.py

@@ -1,4 +1,4 @@
-# $Id: client.py,v 1.197 2004-11-08 23:29:45 richard Exp $
+# $Id: client.py,v 1.198 2004-11-11 21:10:05 richard Exp $
 
 """WWW request handler (also used in the stand-alone server).
 """
@@ -641,26 +641,26 @@ def renderContext(self):
             return cgitb.pt_html(i18n=self.translator)
 
     # these are the actions that are available
-    actions = (
-        ('edit',        EditItemAction),
-        ('editcsv',     EditCSVAction),
-        ('new',         NewItemAction),
-        ('register',    RegisterAction),
-        ('confrego',    ConfRegoAction),
-        ('passrst',     PassResetAction),
-        ('login',       LoginAction),
-        ('logout',      LogoutAction),
-        ('search',      SearchAction),
-        ('retire',      RetireAction),
-        ('show',        ShowAction),
-        ('export_csv',  ExportCSVAction),
-    )
+    actions = {
+        'edit':        EditItemAction,
+        'editcsv':     EditCSVAction,
+        'new':         NewItemAction,
+        'register':    RegisterAction,
+        'confrego':    ConfRegoAction,
+        'passrst':     PassResetAction,
+        'login':       LoginAction,
+        'logout':      LogoutAction,
+        'search':      SearchAction,
+        'retire':      RetireAction,
+        'show':        ShowAction,
+        'export_csv':  ExportCSVAction,
+    }
     def handle_action(self):
         ''' Determine whether there should be an Action called.
 
             The action is defined by the form variable :action which
             identifies the method on this object to call. The actions
-            are defined in the "actions" sequence on this class.
+            are defined in the "actions" dictionary on this class.
 
             Actions may return a page (by default HTML) to return to the
             user, bypassing the usual template rendering.
@@ -678,12 +678,17 @@ def handle_action(self):
                 # tracker-defined action
                 action_klass = self.instance.cgi_actions[action]
             else:
-                # go with a default
-                for name, action_klass in self.actions:
-                    if name == action:
-                        break
+                if isinstance(self.actions, type({})):
+                    if not self.actions.has_key(action):
+                        raise ValueError, 'No such action "%s"'%action
+                    action_class = self.actions[action]
                 else:
-                    raise ValueError, 'No such action "%s"'%action
+                    # backwards-compatible sequence
+                    for name, action_klass in self.actions:
+                        if name == action:
+                            break
+                    else:
+                        raise ValueError, 'No such action "%s"'%action
 
             # call the mapped action
             if isinstance(action_klass, type('')):