Skip to content

Commit 2b60b9e

Browse files
author
Richard Jones
committed
reverted the change that had plain() hyperlinking the link displays
that's what link() is for!
1 parent 0a736d0 commit 2b60b9e

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

roundup/htmltemplate.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
# BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE,
1616
# SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
1717
#
18-
# $Id: htmltemplate.py,v 1.56 2002-01-14 07:04:36 richard Exp $
18+
# $Id: htmltemplate.py,v 1.57 2002-01-14 23:31:21 richard Exp $
1919

2020
__doc__ = """
2121
Template engine.
@@ -86,15 +86,13 @@ def do_plain(self, property, escape=0):
8686
linkcl = self.db.classes[propclass.classname]
8787
k = linkcl.labelprop()
8888
if value:
89-
value = '<a href="%s%s">%s</a>'%(propclass.classname, value,
90-
linkcl.get(value, k))
89+
value = linkcl.get(value, k)
9190
else:
9291
value = _('[unselected]')
9392
elif isinstance(propclass, hyperdb.Multilink):
9493
linkcl = self.db.classes[propclass.classname]
9594
k = linkcl.labelprop()
96-
value = ', '.join(['<a href="%s%s">%s</a>'%(propclass.classname,
97-
i, linkcl.get(i, k)) for i in value])
95+
value = ', '.join(value)
9896
else:
9997
s = _('Plain: bad propclass "%(propclass)s"')%locals()
10098
if escape:
@@ -886,6 +884,12 @@ def render(self, form):
886884

887885
#
888886
# $Log: not supported by cvs2svn $
887+
# Revision 1.56 2002/01/14 07:04:36 richard
888+
# . plain rendering of links in the htmltemplate now generate a hyperlink to
889+
# the linked node's page.
890+
# ... this allows a display very similar to bugzilla's where you can actually
891+
# find out information about the linked node.
892+
#
889893
# Revision 1.55 2002/01/14 06:45:03 richard
890894
# . #502953 ] nosy-like treatment of other multilinks
891895
# ... had to revert most of the previous change to the multilink field

0 commit comments

Comments
 (0)