HTML* classes for cgi: handle MissingValue case

Author: schlatterbeck

roundup/cgi/templating.py

@@ -1938,6 +1938,9 @@ def __getitem__(self, item):
            due to __getattr__ returning the __getitem__ of HTMLItem -- this
            lookup doesn't work for new-style classes.
         """
+        if not self._value:
+            msg = self._('Attempt to look up %(item)s on a missing value')
+            return MissingValue(msg%locals())
         i = HTMLItem(self._client, self._prop.classname, self._value)
         return i[item]
 

test/db_test_base.py

@@ -2536,6 +2536,9 @@ def setUp(self):
         issue = {'title': 'ts1', 'status': '2', 'assignedto': '3',
                 'priority': '3', 'messages' : [u_m], 'nosy' : ['3']}
         self.db.issue.create(**issue)
+        issue = {'title': 'ts2', 'status': '2',
+                'messages' : [u_m], 'nosy' : ['3']}
+        self.db.issue.create(**issue)
 
     def testHTMLItemAttributes(self):
         issue = HTMLItem(self.client, 'issue', '1')
@@ -2578,4 +2581,19 @@ def testHTMLItemDereference(self):
             ae(n['author']['username'].plain(),'worker5')
 
 
+    def testHTMLItemDerefFail(self):
+        issue = HTMLItem(self.client, 'issue', '2')
+        ae = self.assertEqual
+        ae(issue.assignedto.plain(),'')
+        ae(issue ['assignedto'].plain(),'')
+        ae(issue.priority.plain(),'')
+        ae(issue ['priority'].plain(),'')
+        m = '[Attempt to look up %s on a missing value]'
+        ae(str(issue.priority.name),m%'name')
+        ae(str(issue ['priority'].name),m%'name')
+        ae(str(issue.assignedto.username),m%'username')
+        ae(str(issue ['assignedto'].username),m%'username')
+        ae(bool(issue ['assignedto']['username']),False)
+        ae(bool(issue ['priority']['name']),False)
+
 # vim: set et sts=4 sw=4 :