Automatically find out author of property-only changes...

...and add that information in the header of the generated message,
replacing "System Message".

Author: Erik Forsberg

roundup/roundupdb.py

@@ -16,7 +16,7 @@
 # BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE,
 # SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
 #
-# $Id: roundupdb.py,v 1.131 2007-09-05 06:13:56 a1s Exp $
+# $Id: roundupdb.py,v 1.132 2007-09-10 19:18:31 forsberg Exp $
 
 """Extending hyperdb with types specific to issue-tracking.
 """
@@ -283,15 +283,12 @@ def send_message(self, nodeid, msgid, note, sendto, from_address=None,
         # figure author information
         if msgid:
             authid = messages.get(msgid, 'author')
-            authname = users.get(authid, 'realname')
-            if not authname:
-                authname = users.get(authid, 'username', '')
-            authaddr = users.get(authid, 'address', '')
         else:
-            # "system message"
-            authid = None
-            authname = 'admin'
-            authaddr = self.db.config.ADMIN_EMAIL
+            authid = self.db.getuid()
+        authname = users.get(authid, 'realname')
+        if not authname:
+            authname = users.get(authid, 'username', '')
+        authaddr = users.get(authid, 'address', '')
 
         if authaddr and self.db.config.MAIL_ADD_AUTHOREMAIL:
             authaddr = " <%s>" % straddr( ('',authaddr) )
@@ -311,12 +308,11 @@ def send_message(self, nodeid, msgid, note, sendto, from_address=None,
 
                 m.append(_("New submission from %(authname)s%(authaddr)s:")
                     % locals())
-            else:
+            elif msgid:
                 m.append(_("%(authname)s%(authaddr)s added the comment:")
                     % locals())
-            m.append('')
-        elif self.db.config.MAIL_ADD_AUTHORINFO:
-            m.append(_("System message:"))
+            else:
+                m.append(_("Change by %(authname)s%(authaddr)s:") % locals())
             m.append('')
 
         # add the content

test/test_mailgw.py

@@ -8,7 +8,7 @@
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 #
-# $Id: test_mailgw.py,v 1.87 2007-09-01 16:30:11 forsberg Exp $
+# $Id: test_mailgw.py,v 1.88 2007-09-10 19:18:39 forsberg Exp $
 
 # TODO: test bcc
 
@@ -439,6 +439,50 @@ def testFollowup(self):
 _______________________________________________________________________
 ''')
 
+    def testPropertyChangeOnly(self):
+        self.doNewIssue()
+        oldvalues = self.db.getnode('issue', '1').copy()
+        oldvalues['assignedto'] = None
+        self.db.issue.set('1', assignedto=self.chef_id)
+        self.db.commit()
+        self.db.issue.nosymessage('1', None, oldvalues)
+
+
+        new_mail = ""
+        for line in self._get_mail().split("\n"):
+            if "Message-Id: " in line:
+                continue
+            if "Date: " in line:
+                continue
+            new_mail+=line+"\n"
+
+        self.compareMessages(new_mail, """
+FROM: [email protected]
+TO: [email protected], richard@test
+Content-Type: text/plain; charset=utf-8
+Subject: [issue1] Testing...
+To: [email protected], richard@test
+From: "Bork, Chef" <[email protected]>
+X-Roundup-Name: Roundup issue tracker
+X-Roundup-Loop: hello
+X-Roundup-Version: 1.3.3
+MIME-Version: 1.0
+Reply-To: Roundup issue tracker <[email protected]>
+Content-Transfer-Encoding: quoted-printable
+
+
+Change by Bork, Chef <[email protected]>:
+
+
+----------
+assignedto:  -> Chef
+
+_______________________________________________________________________
+Roundup issue tracker <[email protected]>
+<http://tracker.example/cgi-bin/roundup.cgi/bugs/issue1>
+_______________________________________________________________________
+""")
+        
 
     #
     # FOLLOWUP TITLE MATCH