Skip to content

Commit 23e391f

Browse files
committed
issue2551398 - Browser number input
Disable use of native browser number inputs. There are issues including use of comma decimal separators. More extensive remditaion/granularity is needed for this so disable but leave available for people to test with for now. Also moved the implentation of native date type from fixed area to feature area because of the issues with the native date popup and it defaulting to off. This means it's not a bugfix for the various bugs lodged against the roundup date picker component.
1 parent abbe039 commit 23e391f

File tree

2 files changed

+12
-9
lines changed

2 files changed

+12
-9
lines changed

CHANGES.txt

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -77,12 +77,6 @@ Fixed:
7777
- issue2551391, partial fix for issue1513369. input fields were
7878
not getting id's assigned. Fixed automatic id assignment to
7979
input fields. Thinko in the code. (John Rouillard)
80-
- issue2551390 - Replace text input/calendar popup with native
81-
date input. Also add double-click and exit keyboard handlers to
82-
allow copy/paste/editing the text version of the date. Configurable
83-
via the use_browser_date_input setting in the [web] section of
84-
config.ini. By default browser native dates are turned off.
85-
(John Rouillard, Ralf Schlatterbeck)
8680
- issue1895197 - translated help texts in admin.py not displayed
8781
correctly. (Initial patch tobias-herp, John Rouillard)
8882
- issue2551238 - roundup-server should exit with error if -d
@@ -136,10 +130,19 @@ Features:
136130
- Added new templating utils.set_http_response(integer) method to
137131
allow reporting an error to the user from a template. (John
138132
Rouillard)
133+
- issue2551390 - Replace text input/calendar popup with native
134+
date input. Also add double-click and exit keyboard handlers to
135+
allow copy/paste/editing the text version of the date. Configurable
136+
via the use_browser_date_input setting in the [web] section of
137+
config.ini. By default browser native dates are turned off.
138+
(John Rouillard, Ralf Schlatterbeck)
139139
- Use native number type input for Number() and Integer()
140140
properties. Integer() uses step=1 as well. Configurable via the
141-
use_browser_number_input setting in the [web] section of config.ini
142-
(John Rouillard, Ralf Schlatterbeck)
141+
use_browser_number_input setting in the [web] section of config.ini.
142+
Set off by default. See
143+
https://issues.roundup-tracker.org/issue2551398 for discussion of
144+
issues with native number inputs. (John Rouillard, Ralf
145+
Schlatterbeck)
143146
- issue2551231 - template.py-HTMLClass::classhelp doesn't merge
144147
user defined classes. It now merges them in. (John Rouillard)
145148

roundup/configuration.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1469,7 +1469,7 @@ def str2value(self, value):
14691469
"international date format server-side) and some browsers\n"
14701470
"ignore the date format set by the operating system, the\n"
14711471
"default is 'no'."),
1472-
(BooleanOption, "use_browser_number_input", "yes",
1472+
(BooleanOption, "use_browser_number_input", "no",
14731473
"HTML input elements for Number properties: This determines\n"
14741474
"if we use the input type 'number' for Number (and Integer)\n"
14751475
"properties. If set to 'no' we use input type 'text'."),

0 commit comments

Comments
 (0)