Skip to content

Commit 2365bb3

Browse files
committed
Remove the tsearch2 backend
The documentation within the tsearch2 backend labels it as being experimental and that it should not be used. The have_backend() function in roundup.backend returns False indicating that it does not exist and is labeled as "currently not working". The PostgreSQL website also seems to indicate that it has been deprecated since v8.3 when text searching was integrated into the core[1]. Considering all this, it seems like the best option is to just remove the tsearch2 backend. [1] http://www.postgresql.org/docs/9.4/static/tsearch2.html
1 parent c536710 commit 2365bb3

File tree

6 files changed

+0
-1041
lines changed

6 files changed

+0
-1041
lines changed

2to3-done.txt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
CAN'T VERIFY
22

33
./roundup/backends/back_mysql.py
4-
./roundup/backends/back_tsearch2.py
54

65
TODO
76

@@ -109,7 +108,6 @@ TODO
109108
./test/test_templating.py
110109
./test/test_textfmt.py
111110
./test/test_token.py
112-
./test/test_tsearch2.py
113111
./test/test_userauditor.py
114112
./test/test_xmlrpc.py
115113
./test.py
@@ -149,7 +147,6 @@ NOTHING DONE
149147
./roundup/anypy/__init__.py
150148
./roundup/backends/blobfiles.py
151149
./roundup/backends/indexer_xapian.py
152-
./roundup/backends/tsearch2_setup.py
153150
./roundup/cgi/__init__.py
154151
./roundup/cgi/apache.py
155152
./roundup/cgi/client.py

roundup/backends/__init__.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
_modules = {
2929
'mysql': ('MySQLdb',),
3030
'postgresql': ('psycopg',),
31-
'tsearch2': ('psycopg',),
3231
'sqlite': ('pysqlite', 'pysqlite2', 'sqlite3', '_sqlite3', 'sqlite'),
3332
}
3433

@@ -46,9 +45,6 @@ def get_backend(name):
4645

4746
def have_backend(name):
4847
'''Is backend "name" available?'''
49-
if name == 'tsearch2':
50-
# currently not working
51-
return 0
5248
try:
5349
get_backend(name)
5450
return 1

roundup/backends/back_tsearch2.py

Lines changed: 0 additions & 176 deletions
This file was deleted.

0 commit comments

Comments
 (0)