Skip to content

Commit 212f86a

Browse files
Bernhard ReiterBernhard Reiter
authored andcommitted
issue2550695: 'No sort or group' settings not retained when editing queries.
Reported and fixed by John Kristensen. Tested by Satchidanand Haridas.
1 parent 2cff49f commit 212f86a

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

CHANGES.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@ Entries without name were done by Richard Jones.
88
Features:
99
Fixed:
1010

11+
issue2550695: 'No sort or group' settings not retained when editing queries.
12+
Reported and fixed by John Kristensen. Tested by Satchidanand Haridas.
13+
(Bernhard)
14+
1115
2011-07-15 1.4.19 (r4638)
1216

1317
Features:

share/roundup/templates/classic/html/issue.search.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@
1212
cols python:request.columns or 'id activity title status assignedto'.split();
1313
sort_on python:request.sort and request.sort[0] or nothing;
1414
sort_desc python:sort_on and sort_on[0] == '-';
15-
sort_on python:(sort_on and sort_on[1]) or 'activity';
15+
sort_on python:(sort_on and sort_on[1]) or (not request.nodeid and 'activity') or '';
1616
group_on python:request.group and request.group[0] or nothing;
1717
group_desc python:group_on and group_on[0] == '-';
18-
group_on python:(group_on and group_on[1]) or 'priority';
18+
group_on python:(group_on and group_on[1]) or (not request.nodeid and 'priority') or '';
1919
2020
search_input templates/page/macros/search_input;
2121
search_date templates/page/macros/search_date;
@@ -168,8 +168,8 @@
168168
<th i18n:translate="">No Sort or group:</th>
169169
<td>&nbsp;</td>
170170
<td>&nbsp;</td>
171-
<td><input type="radio" name="@sort" value=""></td>
172-
<td><input type="radio" name="@group" value=""></td>
171+
<td><input type="radio" name="@sort" value="" tal:attributes="checked python:sort_on == ''"></td>
172+
<td><input type="radio" name="@group" value="" tal:attributes="checked python:group_on == ''"></td>
173173
</tr>
174174

175175
<tr>

0 commit comments

Comments
 (0)