Sorry about this huge checkin!

It's fixing a lot of related stuff in one go though.

. [SF#541941] changing multilink properties by mail
. [SF#526730] search for messages capability
. [SF#505180] split MailGW.handle_Message
  - also changed cgi client since it was duplicating the functionality
. build htmlbase if tests are run using CVS checkout (removed note from
  installation.txt)
. don't create an empty message on email issue creation if the email is empty

Author: Richard Jones

CHANGES.txt

@@ -32,7 +32,11 @@ Feature:
  . applied patch #558876 ] cgi client customization
  . split instance initialisation into two steps, allowing config changes
    before the database is initialised.
+ . don't create an empty message on email issue creation if the email is empty
+ . #541941 ] changing multilink properties by mail
  . #526730 ] search for messages capability
+ . #505180 ] split MailGW.handle_Message
+   - also changed cgi client since it was duplicating the functionality
 
 Fixed:
  . stop sending blank (whitespace-only) notes
@@ -58,6 +62,7 @@ Fixed:
  . cleaned out the template stylesheets, removing a bunch of junk that really
    wasn't necessary (font specs, styles never used) and added a style for 
    message content
+ . build htmlbase if tests are run using CVS checkout
 
 2002-03-25 - 0.4.1
 Feature:

MANIFEST.in

@@ -5,5 +5,5 @@ recursive-include test *.py *.txt
 recursive-include doc *.html *.png *.txt
 exclude doc/announcement.txt
 include roundup-*
-include *.txt
+include run_tests *.txt
 

MIGRATION.txt

@@ -9,18 +9,7 @@ This file contains information for users upgrading from:
   0.3.x -> 0.4.x
   0.2.x -> 0.3.x
 
-From CVS
-========
-
-Files storage
--------------
-
-Messages and files from newly created issues will be put into subdierectories
-in thousands e.g. msg123 will be put into files/msg/0/msg123, file2003
-will go into files/file/2/file2003. Previous messages are still found, but
-could be put into this structure.
-
-Migrating from 0.4.0 to 0.4.1
+Migrating from 0.4.1 to 0.4.2
 =============================
 
 Configuration
@@ -38,9 +27,30 @@ The new configuration variables are:
 - ADD_RECIPIENTS_TO_NOSY
 
 
+Mail Gateway
+------------
+
+You will need to copy the detectors from the distribution into your instance
+home detectors directory. The schema-specific code has been removed from the
+mail gateway and made into auditors:
+
+- nosyreactor.py has now got an updatenosy auditor which updates the nosy
+  list with author, recipient and assignedto information.
+- statusauditor.py makes the unread or resolved -> chatting changes and
+  presets the status of an issue to unread.
+
+
 Migrating from 0.4.0 to 0.4.1
 =============================
 
+Files storage
+-------------
+
+Messages and files from newly created issues will be put into subdierectories
+in thousands e.g. msg123 will be put into files/msg/0/msg123, file2003
+will go into files/file/2/file2003. Previous messages are still found, but
+could be put into this structure.
+
 Configuration
 -------------
 
@@ -68,8 +78,6 @@ the appropriate variables in instance_config.py.
 The extended schema has similar variables added too - see the source for more
 info.
 
-
-
 Alternate E-Mail Addresses
 --------------------------
 

doc/installation.txt

@@ -2,7 +2,7 @@
 Installing Roundup
 ==================
 
-:Version: $Revision: 1.10 $
+:Version: $Revision: 1.11 $
 
 .. contents::
 
@@ -69,10 +69,6 @@ Testing your Python
 Run ``"python ./run_tests"`` and make sure there
 are no errors.  If there are errors, please let us know!
 
-Note: if you're installing from the CVS, you will need to run "python setup.py
-build" before the tests will work, as there are modules that must be
-generated that are not stored in the CVS.
-
 
 Getting Roundup
 ===============

doc/user_guide.txt

@@ -2,7 +2,7 @@
 User Guide
 ==========
 
-:Version: $Revision: 1.3 $
+:Version: $Revision: 1.4 $
 
 .. contents::
 
@@ -222,7 +222,22 @@ Setting Properties
 The e-mail interface also provides a simple way to set properties on items. At
 the end of the subject line, propname=value pairs can be specified in square
 brackets, using the same conventions as for the roundup set shell command.
-explanatory message given in the exception.
+
+For example,
+
+- setting the priority of an issue::
+
+   Subject: Re: [issue1] the coffee machine is broken! [priority=urgent]
+
+- adding yourself to a nosy list (both of these are equivalent)::
+
+   Subject: Re: [issue2] we're out of widgets [nosy=+richard]
+   Subject: Re: [issue2] we're out of widgets [nosy=richard]
+
+- removing yourself from a nosy list::
+
+   Subject: Re: [issue2] we're out of widgets [nosy=-richard]
+
 
 Message content
 ~~~~~~~~~~~~~~~

roundup/cgi_client.py

@@ -15,7 +15,7 @@
 # BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE,
 # SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
 # 
-# $Id: cgi_client.py,v 1.125 2002-05-25 07:16:24 rochecompaan Exp $
+# $Id: cgi_client.py,v 1.126 2002-05-29 01:16:17 richard Exp $
 
 __doc__ = """
 WWW request handler (also used in the stand-alone server).
@@ -604,86 +604,10 @@ def shownode(self, message=None):
     showmsg = shownode
     searchissue = searchnode
 
-    def _add_author_to_nosy(self, props):
-        ''' add the author value from the props to the nosy list
-        '''
-        if not props.has_key('author'):
-            return
-        author_id = props['author']
-        if not props.has_key('nosy'):
-            # load current nosy
-            if self.nodeid:
-                cl = self.db.classes[self.classname]
-                l = cl.get(self.nodeid, 'nosy')
-                if author_id in l:
-                    return
-                props['nosy'] = l
-            else:
-                props['nosy'] = []
-        if author_id not in props['nosy']:
-            props['nosy'].append(author_id)
-
-    def _add_assignedto_to_nosy(self, props):
-        ''' add the assignedto value from the props to the nosy list
-        '''
-        # get the properties definition and make some checks
-        if not props.has_key('assignedto'):
-            return
-        cl = self.db.classes[self.classname]
-        propdef = cl.getprops()
-        if not propdef.has_key('assignedto') or not propdef.has_key('nosy'):
-            return
-
-        # get the assignedto(s)
-        if isinstance(propdef['assignedto'], hyperdb.Link):
-            assignedto_ids = [props['assignedto']]
-        elif isinstance(propdef['assignedto'], hyperdb.Multilink):
-            assignedto_ids = props['assignedto']
-        else:
-            return
-
-        # ok, now get the nosy list value
-        if not props.has_key('nosy'):
-            # load current nosy
-            if self.nodeid:
-                props['nosy'] = cl.get(self.nodeid, 'nosy')
-            else:
-                props['nosy'] = []
-
-        # and update for assignedto id(s)
-        for assignedto_id in assignedto_ids:
-            if assignedto_id not in props['nosy']:
-                props['nosy'].append(assignedto_id)
-
     def _changenode(self, props):
         ''' change the node based on the contents of the form
         '''
         cl = self.db.classes[self.classname]
-        # set status to chatting if 'unread' or 'resolved'
-        try:
-            # determine the id of 'unread','resolved' and 'chatting'
-            unread_id = self.db.status.lookup('unread')
-            resolved_id = self.db.status.lookup('resolved')
-            chatting_id = self.db.status.lookup('chatting')
-            current_status = cl.get(self.nodeid, 'status')
-            if props.has_key('status'):
-                new_status = props['status']
-            else:
-                # apparently there's a chance that some browsers don't
-                # send status...
-                new_status = current_status
-        except KeyError:
-            pass
-        else:
-            if new_status == unread_id or (new_status == resolved_id
-                    and current_status == resolved_id):
-                props['status'] = chatting_id
-
-        self._add_assignedto_to_nosy(props)
-
-        # possibly add the author of the change to the nosy list
-        if self.db.config.ADD_AUTHOR_TO_NOSY == 'yes':
-            self._add_author_to_nosy(props)
 
         # create the message
         message, files = self._handle_message()
@@ -701,22 +625,6 @@ def _createnode(self):
         cl = self.db.classes[self.classname]
         props = parsePropsFromForm(self.db, cl, self.form)
 
-        # set status to 'unread' if not specified - a status of '- no
-        # selection -' doesn't make sense
-        if not props.has_key('status') and cl.getprops().has_key('status'):
-            try:
-                unread_id = self.db.status.lookup('unread')
-            except KeyError:
-                pass
-            else:
-                props['status'] = unread_id
-
-        self._add_assignedto_to_nosy(props)
-
-        # possibly add the author of the new node to the nosy list
-        if self.db.config.ADD_AUTHOR_TO_NOSY in ('new', 'yes'):
-            self._add_author_to_nosy(props)
-
         # check for messages and files
         message, files = self._handle_message()
         if message:
@@ -1454,6 +1362,9 @@ def parsePropsFromForm(db, cl, form, nodeid=0):
 
 #
 # $Log: not supported by cvs2svn $
+# Revision 1.125  2002/05/25 07:16:24  rochecompaan
+# Merged search_indexing-branch with HEAD
+#
 # Revision 1.124  2002/05/24 02:09:24  richard
 # Nothing like a live demo to show up the bugs ;)
 #