Skip to content

Commit 2005dde

Browse files
committed
Remove 'import *' statement from cgi/client.py
There are various 'import *' statements scattered through the code which are generally not a good thing. These should be fairly safe changes, but I'll commit them one file at a time to make it easier to track down issues with a bisect if they crop up later.
1 parent 0af23dc commit 2005dde

File tree

1 file changed

+16
-14
lines changed

1 file changed

+16
-14
lines changed

roundup/cgi/client.py

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,11 @@
1515

1616
from roundup import roundupdb, date, hyperdb, password
1717
from roundup.cgi import templating, cgitb, TranslationService
18-
from roundup.cgi.actions import *
18+
from roundup.cgi import actions
1919
from roundup.exceptions import LoginError, Reject, RejectRaw, Unauthorised
20-
from roundup.cgi.exceptions import *
20+
from roundup.cgi.exceptions import (
21+
FormError, NotFound, NotModified, Redirect, SendFile, SendStaticFile,
22+
SeriousError)
2123
from roundup.cgi.form_parser import FormParser
2224
from roundup.mailer import Mailer, MessageSendError, encode_quopri
2325
from roundup.cgi import accept_language
@@ -1222,18 +1224,18 @@ def renderContext(self):
12221224

12231225
# these are the actions that are available
12241226
actions = (
1225-
('edit', EditItemAction),
1226-
('editcsv', EditCSVAction),
1227-
('new', NewItemAction),
1228-
('register', RegisterAction),
1229-
('confrego', ConfRegoAction),
1230-
('passrst', PassResetAction),
1231-
('login', LoginAction),
1232-
('logout', LogoutAction),
1233-
('search', SearchAction),
1234-
('retire', RetireAction),
1235-
('show', ShowAction),
1236-
('export_csv', ExportCSVAction),
1227+
('edit', actions.EditItemAction),
1228+
('editcsv', actions.EditCSVAction),
1229+
('new', actions.NewItemAction),
1230+
('register', actions.RegisterAction),
1231+
('confrego', actions.ConfRegoAction),
1232+
('passrst', actions.PassResetAction),
1233+
('login', actions.LoginAction),
1234+
('logout', actions.LogoutAction),
1235+
('search', actions.SearchAction),
1236+
('retire', actions.RetireAction),
1237+
('show', actions.ShowAction),
1238+
('export_csv', actions.ExportCSVAction),
12371239
)
12381240
def handle_action(self):
12391241
""" Determine whether there should be an Action called.

0 commit comments

Comments
 (0)