fix roundup-server log and PID file paths to be absolute

fix initialisation of roundup-server in daemon mode so initialisation
errors are visible

Author: Richard Jones

CHANGES.txt

@@ -1,6 +1,13 @@
 This file contains the changes to the Roundup system over time. The entries
 are given with the most recent entry first.
 
+2005-01-?? 0.8.0
+Fixed:
+- fix roundup-server log and PID file paths to be absolute
+- fix initialisation of roundup-server in daemon mode so initialisation
+  errors are visible
+
+
 2005-01-13 0.8.0b2
 Fixed:
 - note about how to run roundup demo in Windows (sf bug 1082090)

roundup/scripts/roundup_server.py

@@ -17,7 +17,7 @@
 
 """Command-line script that runs a server over roundup.cgi.client.
 
-$Id: roundup_server.py,v 1.74.2.1 2004-12-22 06:38:08 a1s Exp $
+$Id: roundup_server.py,v 1.74.2.2 2005-01-15 06:53:00 richard Exp $
 """
 __docformat__ = 'restructuredtext'
 
@@ -392,13 +392,13 @@ def trackers(self):
                 self["TRACKERS_" + option.upper()])))
         return trackers
 
+    def set_logging(self):
+        """Initialise logging to the configured file, if any."""
+        # appending, unbuffered
+        sys.stdout = sys.stderr = open(self["LOGFILE"], 'a', 0)
+
     def get_server(self):
         """Return HTTP server object to run"""
-        # redirect stdout/stderr to our logfile
-        # this is done early to have following messages go to this logfile
-        if self["LOGFILE"]:
-            # appending, unbuffered
-            sys.stdout = sys.stderr = open(self["LOGFILE"], 'a', 0)
         # we don't want the cgi module interpreting the command-line args ;)
         sys.argv = sys.argv[:1]
         # preload all trackers unless we are in "debug" mode
@@ -478,6 +478,7 @@ def SvcDoRun(self):
                     (self._svc_display_name_, "\r\nMissing logfile option"))
                 self.ReportServiceStatus(win32service.SERVICE_STOPPED)
                 return
+            config.set_logging()
             self.server = config.get_server()
             self.running = 1
             self.ReportServiceStatus(win32service.SERVICE_RUNNING)
@@ -605,7 +606,7 @@ def daemonize(pidfile):
     os.chdir("/")
     os.umask(0)
 
-    # close off sys.std(in|out|err), redirect to devnull so the file
+    # close off std(in|out|err), redirect to devnull so the file
     # descriptors can't be used again
     devnull = os.open('/dev/null', 0)
     os.dup2(devnull, 0)
@@ -689,6 +690,13 @@ def run(port=undefined, success_message=None):
     if port is not undefined:
         config.PORT = port
 
+    if config["LOGFILE"]:
+        config["LOGFILE"] = os.path.abspath(config["LOGFILE"])
+        # switch logging from stderr/stdout to logfile
+        config.set_logging()
+    if config["PIDFILE"]:
+        config["PIDFILE"] = os.path.abspath(config["PIDFILE"])
+
     # fork the server from our parent if a pidfile is specified
     if config["PIDFILE"]:
         if not hasattr(os, 'fork'):