Skip to content

Commit 1e5a27e

Browse files
author
Gordon B. McMillan
committed
Fix bug in setting activity.
1 parent 22fdfab commit 1e5a27e

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

roundup/backends/back_metakit.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ def getWriteAccess(self):
193193

194194
_ALLOWSETTINGPRIVATEPROPS = 0
195195

196-
class Class: # no, I'm not going to subclass the existing!
196+
class Class:
197197
privateprops = None
198198
def __init__(self, db, classname, **properties):
199199
self.db = weakref.proxy(db)
@@ -461,7 +461,7 @@ def set(self, nodeid, **propvalues):
461461
# nothing to do?
462462
if not propvalues:
463463
return
464-
if not row.activity:
464+
if not propvalues.has_key('activity'):
465465
row.activity = int(time.time())
466466
if isnew:
467467
if not row.creation:
@@ -720,12 +720,11 @@ def ff(row, r=regexes):
720720
try:
721721
prop = getattr(v, propname)
722722
except AttributeError:
723-
# I can't sort on 'activity', cause it's psuedo!!
724723
continue
725724
if isreversed:
726725
rev.append(prop)
727726
sortspec.append(prop)
728-
v = v.sortrev(sortspec, rev)[:] #XXX Aaaabh
727+
v = v.sortrev(sortspec, rev)[:] #XXX Metakit bug
729728
#print "filter sort at %s" % time.time()
730729

731730
rslt = []

0 commit comments

Comments
 (0)