fix: duplicate password id generated for user.item.html

Fix the user_confirm_input macro at the end of html/page.html to
modify the id so it doesn't duplicate the one used for the regular
password.

Author: rouilj

CHANGES.txt

@@ -71,6 +71,8 @@ Fixed:
   newer. dicttoxml uses a type alias: collection.Iterator that is
   dropped in Python 3.10. (found by Norbert SCHLEMMER, fix John
   Rouillard)
+- fix repeated password id with user.item.html in all templates except
+  jinja2. (John Rouillard)
 
 Features:
 

doc/upgrading.txt

@@ -112,6 +112,29 @@ values or if a value must be changed manually.
 
 This will insert the bad API login rate limiting settings.
 
+Fix duplicate id for confirm password in user.item.html (optional)
+------------------------------------------------------------------
+
+The TAL macro ``user_confirm_input`` at the end of ``html/page.html``
+for all templates except ``jinja2`` sets the ``id`` of the ``Confirm
+password`` input the same as the ``Login Password`` input. This
+creates an HTML error. Two items must not have the same id.
+
+However browsers ignore the error and things still work.  If you were
+to use css or javascript to target the ``password`` id, it would not
+work as expected.
+
+To fix this, change the line near the end of your tracker's
+``html/page.html`` from::
+
+ tal:attributes="id name; name string:@confirm@$name; readonly not:edit_ok" value="">
+
+to::
+
+ tal:attributes="id string:confirm_$name; name string:@confirm@$name; readonly not:edit_ok" value="">
+
+This will change the id to ``confirm_password``.
+
 Bad Login Rate Limiting and Locking (info)
 ------------------------------------------
 

share/roundup/templates/classic/html/page.html

@@ -369,5 +369,5 @@ <h2><span metal:define-slot="body_title">body title</span></h2>
     <input metal:define-macro="user_pw_input" type="password"
     tal:attributes="id name; name name; readonly not:edit_ok" value="">
     <input metal:define-macro="user_confirm_input" type="password"
-    tal:attributes="id name; name string:@confirm@$name; readonly not:edit_ok" value="">
+    tal:attributes="id string:confirm_$name; name string:@confirm@$name; readonly not:edit_ok" value="">
 

share/roundup/templates/devel/html/page.html

@@ -434,6 +434,6 @@ <h1 id="breadcrumb"><span metal:define-slot="body_title">body title</span></h1>
     <input metal:define-macro="user_pw_input" type="password"
     tal:attributes="id name; name name; readonly not:edit_ok" value=""/>
     <input metal:define-macro="user_confirm_input" type="password"
-    tal:attributes="id name; name string:@confirm@$name; readonly not:edit_ok" value=""/>
+    tal:attributes="id string:confirm_$name; name string:@confirm@$name; readonly not:edit_ok" value=""/>
 
 <!-- SHA: ca32e5f43efcb7c3b4940df6f7a176f6990b15f0 -->

share/roundup/templates/minimal/html/page.html

@@ -341,5 +341,5 @@ <h2><span metal:define-slot="body_title">body title</span></h2>
     <input metal:define-macro="user_pw_input" type="password"
     tal:attributes="id name; name name; readonly not:edit_ok" value="">
     <input metal:define-macro="user_confirm_input" type="password"
-    tal:attributes="id name; name string:@confirm@$name; readonly not:edit_ok" value="">
+    tal:attributes="id string:confirm_$name; name string:@confirm@$name; readonly not:edit_ok" value="">
 

share/roundup/templates/responsive/html/page.html

@@ -449,4 +449,4 @@ <h1><span metal:define-slot="body_title">body title</span></h1>
     <input metal:define-macro="user_pw_input" type="password"
     tal:attributes="id name; name name; readonly not:edit_ok" value=""/>
     <input metal:define-macro="user_confirm_input" type="password"
-    tal:attributes="id name; name string:@confirm@$name; readonly not:edit_ok" value=""/>
+    tal:attributes="id string:confirm_$name; name string:@confirm@$name; readonly not:edit_ok" value=""/>