Bug-Fix: File attachments from the web-interface didn't work.

Added test for file attachments.

Author: Ralf Schlatterbeck

roundup/cgi/actions.py

@@ -1,4 +1,4 @@
-#$Id: actions.py,v 1.69 2007-05-09 06:18:52 schlatterbeck Exp $
+#$Id: actions.py,v 1.70 2007-05-15 16:23:39 schlatterbeck Exp $
 
 import re, cgi, StringIO, urllib, Cookie, time, random, csv, codecs
 
@@ -367,7 +367,8 @@ def _editnodes(self, all_props, all_links):
         deps = {}
         links = {}
         for cn, nodeid, propname, vlist in all_links:
-            if not (nodeid or all_props.has_key((cn, nodeid))):
+            numeric_id = int (nodeid or 0)
+            if not (numeric_id > 0 or all_props.has_key((cn, nodeid))):
                 # link item to link to doesn't (and won't) exist
                 continue
 

test/test_actions.py

@@ -246,7 +246,10 @@ def __call__(inner_self, *args, **kw):
         self.client.db.classes.create = AppendResult('create')
         self.client.db.classes.set = AppendResult('set')
         self.client.db.classes.getprops = lambda: \
-            ({'messages':hyperdb.Multilink('msg'), 'content':hyperdb.String()})
+            ({'messages':hyperdb.Multilink('msg')
+             ,'content':hyperdb.String()
+             ,'files':hyperdb.Multilink('file')
+             })
         self.action = EditItemAction(self.client)
 
     def testMessageAttach(self):
@@ -265,6 +268,27 @@ def testMessageAttach(self):
             pass
         self.assertEqual(expect, self.result)
 
+    def testFileAttach(self):
+        expect = \
+            [('create',(),{'content':'t','type':'text/plain','name':'t.txt'})
+            ,('set',('4711',),{'files':['23','42','17']})
+            ]
+        self.client.db.classes.get = lambda a, b:['23','42']
+        self.client.parsePropsFromForm = lambda: \
+            ( {('file','-1'):{'content':'t','type':'text/plain','name':'t.txt'}
+              ,('issue','4711'):{}
+              }
+            , [('issue','4711','messages',[('msg','-1')])
+              ,('issue','4711','files',[('file','-1')])
+              ,('msg','-1','files',[('file','-1')])
+              ]
+            )
+        try :
+            self.action.handle()
+        except Redirect, msg:
+            pass
+        self.assertEqual(expect, self.result)
+
     def testLinkExisting(self):
         expect = [('set',('4711',),{'messages':['23','42','1']})]
         self.client.db.classes.get = lambda a, b:['23','42']