- issue2550796: Calendar and Classhelp selection tools don't cause

  onchange event to be triggered.
  Using the helper popups for modifying lists of users, lists of
  issues, dates etc.. now trigger the change event on the form's
  field. This allows onchange javascript to trigger to highlight
  changes, recalculate other form values etc.  See ``upgrading.txt``
  for details on applying these changes to your tracker.

Author: rouilj

CHANGES.txt

@@ -149,6 +149,13 @@ Features:
 - Number properties now have an optional attribute use_double to request
   double precision float as the storage type for this property. (Ralf
   Schlatterbeck)
+- issue2550796: Calendar and Classhelp selection tools don't cause
+  onchange event to be triggered.
+  Using the helper popups for modifying lists of users, lists of
+  issues, dates etc.. now trigger the change event on the form's
+  field. This allows onchange javascript to trigger to highlight
+  changes, recalculate other form values etc.  See ``upgrading.txt``
+  for details on applying these changes to your tracker. (John Rouillard)
 
 Fixed:
 

doc/upgrading.txt

@@ -207,6 +207,34 @@ the page for the newly created item. The url value assigned to
 __redirect_to must be under the tracker's base url and must be properly
 url encoded.
 
+Helper popups trigger change events on the original page
+--------------------------------------------------------
+
+The helper popups used to set dates (from a calendar), change lists of
+users or lists of issues did not notify the browser that the fields
+had been changed. This release adds code to trigger the change event.
+
+To add the change event to the calendar popup, you don't need to do
+any changes to the tracker. It is all done in the roundup python code
+in templating.py.
+
+To add the change event when updating users using the help-submit
+template, copy
+share/roundup/templates/devel/html/_generic.help-submit.html and
+replace your tracker's html/_generic.help-submit.html.  If you have
+done local changes to this file, change your file to include the code
+that defines the onclick event for the input field with
+id="btn_apply".
+
+To add the change event when updating lists of issues copy
+share/roundup/templates/devel/html/help_controls.js to your tracer's
+html directory. If you have made local changes to the javascript file,
+merge the two if/else blocks labeled::
+
+   /* trigger change event on the field we changed */
+
+into your help_controls.js
+
 html/_generic.404.html in trackers use page template
 ----------------------------------------------------
 

roundup/cgi/templating.py

@@ -3083,8 +3083,9 @@ def html_calendar(self, request):
         for week in calendar.monthcalendar(display.year, display.month):
             res.append('  <tr>')
             for day in week:
-                link = "javascript:form[field].value = '%d-%02d-%02d'; " \
-                      "window.close ();"%(display.year, display.month, day)
+                 link = "javascript:form[field].value = '%d-%02d-%02d'; " \
+                      "if ('createEvent' in document) { var evt = document.createEvent('HTMLEvents'); evt.initEvent('change', true, true); form[field].dispatchEvent(evt); } else { form[field].fireEvent('onchange'); }" \
+                       "window.close ();"%(display.year, display.month, day)
                 if (day == curr_date.day and display.month == curr_date.month
                         and display.year == curr_date.year):
                     # highlight

share/roundup/templates/classic/html/_generic.help-submit.html

@@ -61,7 +61,8 @@
      onclick="text_field.value=original_field;f=getListForm();if (f) {reviseList_framed(f, this)};return false"
             />
      <input type="submit" id="btn_apply" class="apply"
-            value=" Apply " onclick="callingform[field].value=text_field.value; parent.close();"
+            value=" Apply " onclick="callingform[field].value=text_field.value;   if ('createEvent' in document) { var evt = document.createEvent('HTMLEvents');  evt.initEvent('change', true, true); callingform[field].dispatchEvent(evt); } else
+{ callingform[field].fireEvent('onchange'); } parent.close();"
             i18n:attributes="value" />
  </form>
  <script type="text/javascript"><!--

share/roundup/templates/classic/html/help_controls.js

@@ -52,12 +52,30 @@ function updateOpener() {
   // write back to opener window
   if (document.frm_help.check==undefined) { return; }
   form[field].value = text_field.value;
+
+  /* trigger change event on the field we changed */
+  if ("createEvent" in document) {
+    var evt = document.createEvent("HTMLEvents");
+    evt.initEvent("change", true, true);
+    form[field].dispatchEvent(evt);
+  }
+    else
+	form[field].fireEvent("onchange");
 }
 
 function updateList() {
   // write back to opener window
   if (document.frm_help.check==undefined) { return; }
   form[field].value = determineList();
+
+  /* trigger change event on the field we changed */
+  if ("createEvent" in document) {
+    var evt = document.createEvent("HTMLEvents");
+    evt.initEvent("change", true, true);
+    form[field].dispatchEvent(evt);
+  }
+    else
+	form[field].fireEvent("onchange");
 }
 
 function updatePreview() {

share/roundup/templates/devel/html/_generic.help-submit.html

@@ -61,7 +61,8 @@
      onclick="text_field.value=original_field;f=getListForm();if (f) {reviseList_framed(f, this)};return false"
             />
      <input type="submit" id="btn_apply" class="apply"
-            value=" Apply " onclick="callingform[field].value=text_field.value; parent.close();"
+            value=" Apply " onclick="callingform[field].value=text_field.value;   if ('createEvent' in document) { var evt = document.createEvent('HTMLEvents');  evt.initEvent('change', true, true); callingform[field].dispatchEvent(evt); } else
+{ callingform[field].fireEvent('onchange'); } parent.close();"
             i18n:attributes="value" />
  </form>
  <script type="text/javascript"><!--

share/roundup/templates/devel/html/help_controls.js

@@ -52,12 +52,30 @@ function updateOpener() {
   // write back to opener window
   if (document.frm_help.check==undefined) { return; }
   form[field].value = text_field.value;
+
+  /* trigger change event on the field we changed */
+  if ("createEvent" in document) {
+    var evt = document.createEvent("HTMLEvents");
+    evt.initEvent("change", true, true);
+    form[field].dispatchEvent(evt);
+  }
+    else
+	form[field].fireEvent("onchange");
 }
 
 function updateList() {
   // write back to opener window
   if (document.frm_help.check==undefined) { return; }
   form[field].value = determineList();
+
+  /* trigger change event on the field we changed */
+  if ("createEvent" in document) {
+    var evt = document.createEvent("HTMLEvents");
+    evt.initEvent("change", true, true);
+    form[field].dispatchEvent(evt);
+  }
+    else
+	form[field].fireEvent("onchange");
 }
 
 function updatePreview() {

share/roundup/templates/responsive/html/_generic.help-submit.html

@@ -61,7 +61,8 @@
      onclick="text_field.value=original_field;f=getListForm();if (f) {reviseList_framed(f, this)};return false"
             />
      <input type="submit" id="btn_apply" class="apply"
-            value=" Apply " onclick="callingform[field].value=text_field.value; parent.close();"
+            value=" Apply " onclick="callingform[field].value=text_field.value;   if ('createEvent' in document) { var evt = document.createEvent('HTMLEvents');  evt.initEvent('change', true, true); callingform[field].dispatchEvent(evt); } else
+{ callingform[field].fireEvent('onchange'); } parent.close();"
             i18n:attributes="value" />
  </form>
  <script type="text/javascript"><!--

share/roundup/templates/responsive/html/help_controls.js

@@ -52,12 +52,30 @@ function updateOpener() {
   // write back to opener window
   if (document.frm_help.check==undefined) { return; }
   form[field].value = text_field.value;
+
+  /* trigger change event on the field we changed */
+  if ("createEvent" in document) {
+    var evt = document.createEvent("HTMLEvents");
+    evt.initEvent("change", true, true);
+    form[field].dispatchEvent(evt);
+  }
+    else
+	form[field].fireEvent("onchange");
 }
 
 function updateList() {
   // write back to opener window
   if (document.frm_help.check==undefined) { return; }
   form[field].value = determineList();
+
+  /* trigger change event on the field we changed */
+  if ("createEvent" in document) {
+    var evt = document.createEvent("HTMLEvents");
+    evt.initEvent("change", true, true);
+    form[field].dispatchEvent(evt);
+  }
+    else
+	form[field].fireEvent("onchange");
 }
 
 function updatePreview() {