handle missing Subject: line [SF#755331]

Author: Richard Jones

CHANGES.txt

@@ -3,6 +3,8 @@ are given with the most recent entry first.
 
 2003-??-?? 0.6.0??
 - plugged cross-site-scripting hole (thanks Jeff Epler)
+- handle deprecation of FCNTL in python2.2+ (sf bug 756756)
+- handle missing Subject: line (sf bug 755331)
 
 
 2003-06-10 0.6.0b3

roundup/mailgw.py

@@ -73,7 +73,7 @@ class node. Any parts of other types are each stored in separate files
 an exception, the original message is bounced back to the sender with the
 explanatory message given in the exception. 
 
-$Id: mailgw.py,v 1.122 2003-06-18 23:31:52 richard Exp $
+$Id: mailgw.py,v 1.123 2003-06-18 23:34:52 richard Exp $
 '''
 
 import string, re, os, mimetools, cStringIO, smtplib, socket, binascii, quopri
@@ -487,6 +487,11 @@ def handle_message(self, message):
         # handle the subject line
         subject = message.getheader('subject', '')
 
+        if not subject:
+            raise MailUsageError, '''
+Emails to Roundup trackers must include a Subject: line!
+'''
+
         if subject.strip().lower() == 'help':
             raise MailUsageHelp