fix: issue2551346, assume statusauditor chatting_requires_two_user off

This option of the statusauditor.py detector prevents a ticket from
going into chatting state if the same user posts multiple updates.

If the setting that controls this was missing from
detector/config.ini, it would generate an error to the user.
Now it just assumes the option is off and doesn't give a big red
banner to the user who can't do anything about it.

Author: rouilj

CHANGES.txt

@@ -135,6 +135,13 @@ Fixed:
   still supported. (John Rouillard)
 - Use roundup-demo -p option to set listening port. Was ignored
   before. (John Rouillard)
+- issue2551346 - Classic tracker's statusauditor raises error if
+  detectors/config.ini missing
+  STATUSAUDITOR_CHATTING_REQUIRES_TWO_USERS.  The statusauditor.py for
+  jinja2 and classic templates has been changed to assume that this
+  option is off when the setting is missing from
+  detectors/config.ini. Other templates do not implement this option.
+  (John Rouillard)
 
 Features:
 

share/roundup/templates/classic/detectors/statusauditor.py

@@ -43,7 +43,11 @@ def chatty(db, cl, nodeid, newvalues):
         'STATUSAUDITOR_CHATTING_REQUIRES_TWO_USERS' ]
     )
     except InvalidOptionError:
-        raise InvalidOptionError("Option STATUSAUDITOR_CHATTING_REQUIRES_TWO_USERS not found in detectors/config.ini. Contact tracker admin to fix.")
+        chatting_requires_two_users = False
+        # NOTE if this is hit, detectors/config.ini needs to be updated with:
+        #   [statusauditor]
+        #   chatting_requires_two_users = yes
+        # to enable or no to disable (same as default)
 
     # don't fire if there's no new message (ie. chat)
     if 'messages' not in newvalues:

share/roundup/templates/jinja2/detectors/statusauditor.py

@@ -43,7 +43,11 @@ def chatty(db, cl, nodeid, newvalues):
         'STATUSAUDITOR_CHATTING_REQUIRES_TWO_USERS' ]
     )
     except InvalidOptionError:
-        raise InvalidOptionError("Option STATUSAUDITOR_CHATTING_REQUIRES_TWO_USERS not found in detectors/config.ini. Contact tracker admin to fix.")
+        chatting_requires_two_users = False
+        # NOTE if this is hit, detectors/config.ini needs to be updated with:
+        #   [statusauditor]
+        #   chatting_requires_two_users = yes
+        # to enable or no to disable (same as default)
 
     # don't fire if there's no new message (ie. chat)
     if 'messages' not in newvalues: