Skip to content

Commit 117415f

Browse files
author
Richard Jones
committed
fixed DateHTMLProperty for invalid date entry [SF#986538]
1 parent c792c2e commit 117415f

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

CHANGES.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ Fixed:
2828
- fix messageid generated when msgid is None for send_message (sf bug 987933)
2929
- make user permissions check more sane (fix search page for anonymous)
3030
- fixed RDBMS filter() for no matches from full-text search (sf bug 990778)
31+
- fixed DateHTMLProperty for invalid date entry (sf bug 986538)
3132

3233

3334
2004-06-24 0.7.5

roundup/cgi/templating.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1378,7 +1378,7 @@ def plain(self):
13781378
offset = self._offset
13791379
return str(self._value.local(offset))
13801380

1381-
def now(self, str_interval = None):
1381+
def now(self, str_interval=None):
13821382
''' Return the current time.
13831383
13841384
This is useful for defaulting a new value. Returns a
@@ -1402,7 +1402,7 @@ def now(self, str_interval = None):
14021402
return DateHTMLProperty(self._client, self._classname, self._nodeid,
14031403
self._prop, self._formname, ret)
14041404

1405-
def field(self, size = 30, default = None):
1405+
def field(self, size=30, default=None):
14061406
''' Render a form edit field for the property
14071407
14081408
If not editable, just display the value via plain().
@@ -1422,12 +1422,14 @@ def field(self, size = 30, default = None):
14221422
else:
14231423
raise ValueError, _('default value for '
14241424
'DateHTMLProperty must be either DateHTMLProperty '
1425-
'or string date representation.')
1425+
'or string date representation.')
14261426
else:
14271427
raw_value = self._value
14281428

14291429
if raw_value is None:
14301430
value = ''
1431+
elif type(raw_value) is type(''):
1432+
value = raw_value
14311433
else:
14321434
tz = self._db.getUserTimezone()
14331435
value = cgi.escape(str(raw_value.local(tz)))

0 commit comments

Comments
 (0)