Skip to content

Commit 0fe6236

Browse files
author
Richard Jones
committed
fix sidebar search links (patch [SF#1574467])
1 parent 7336b30 commit 0fe6236

File tree

3 files changed

+19
-4
lines changed

3 files changed

+19
-4
lines changed

CHANGES.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ Fixed:
1414
- fix sort/group direction checkbox in issue.index.html (sf bug 1593025)
1515
- fix error detection for non-EN locales of postgres (sf bug 1592249)
1616
- fix email change note rendering of multiline properties (sf patch 1575223)
17+
- fix sidebar search links (sf patch 1574467)
1718

1819

1920
2006-10-07 1.2.1

templates/classic/html/page.html

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ <h2><span metal:define-slot="body_title">body title</span></h2>
3939
<input type="hidden" name="@sort" value="activity"/>
4040
<input type="hidden" name="@group" value="priority"/>
4141
<input id="search-text" name="@search_text" size="10"/>
42-
<input type="submit" id="submit" name="submit" value="Search" i18n:attributes="value"/>
42+
<input type="submit" id="submit" name="submit" value="Search" i18n:attributes="value" tal:attributes="value request/search_text" />
4343
</form>
4444
</div>
4545
</td>
@@ -70,6 +70,7 @@ <h2><span metal:define-slot="body_title">body title</span></h2>
7070
'@group': 'priority',
7171
'@filter': 'status,assignedto',
7272
'@columns': columns,
73+
'@search_text': '',
7374
'status': status_notresolved,
7475
'assignedto': '-1',
7576
'@dispname': i18n.gettext('Show Unassigned'),
@@ -81,6 +82,7 @@ <h2><span metal:define-slot="body_title">body title</span></h2>
8182
'@group': 'priority',
8283
'@filter': 'status',
8384
'@columns': columns_showall,
85+
'@search_text': '',
8486
'status': status_notresolved,
8587
'@dispname': i18n.gettext('Show All'),
8688
})"
@@ -141,7 +143,18 @@ <h2><span metal:define-slot="body_title">body title</span></h2>
141143
<p class="userblock" tal:condition="python:request.user.username != 'anonymous'">
142144
<b i18n:translate="">Hello, <span i18n:name="user"
143145
tal:replace="request/user/username">username</span></b><br>
144-
<a href="#" tal:attributes="href string:issue?@sort=-activity&@group=priority&@filter=status,assignedto&@columns=id,activity,title,creator,status&status=-1,1,2,3,4,5,6,7&assignedto=${request/user/id}" i18n:translate="">Your Issues</a><br>
146+
<a href="#"
147+
tal:attributes="href python:request.indexargs_url('issue', {
148+
'@sort': '-activity',
149+
'@group': 'priority',
150+
'@filter': 'status,assignedto',
151+
'@columns': 'id,activity,title,creator,status',
152+
'@search_text': '',
153+
'status': status_notresolved,
154+
'assignedto': request.user.id,
155+
'@dispname': i18n.gettext('Your Issues'),
156+
})"
157+
i18n:translate="">Your Issues</a><br>
145158
<a href="#" tal:attributes="href string:user${request/user/id}"
146159
i18n:translate="">Your Details</a><br>
147160
<a href="#" tal:attributes="href python:request.indexargs_url('',

templates/minimal/html/page.html

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ <h2><span metal:define-slot="body_title">body title</span></h2>
3939
<input type="hidden" name="@sort" value="activity"/>
4040
<input type="hidden" name="@group" value="priority"/>
4141
<input id="search-text" name="@search_text" size="10"/>
42-
<input type="submit" id="submit" name="submit" value="Search" i18n:attributes="value"/>
42+
<input type="submit" id="submit" name="submit" value="Search" i18n:attributes="value" tal:attributes="value request/search_text" />
4343
</form>
4444
</div>
4545
</td>
@@ -70,6 +70,7 @@ <h2><span metal:define-slot="body_title">body title</span></h2>
7070
'@group': 'priority',
7171
'@filter': 'status,assignedto',
7272
'@columns': columns,
73+
'@search_text': '',
7374
'status': status_notresolved,
7475
'assignedto': '-1',
7576
'@dispname': i18n.gettext('Show Unassigned'),
@@ -81,6 +82,7 @@ <h2><span metal:define-slot="body_title">body title</span></h2>
8182
'@group': 'priority',
8283
'@filter': 'status',
8384
'@columns': columns_showall,
85+
'@search_text': '',
8486
'status': status_notresolved,
8587
'@dispname': i18n.gettext('Show All'),
8688
})"
@@ -141,7 +143,6 @@ <h2><span metal:define-slot="body_title">body title</span></h2>
141143
<p class="userblock" tal:condition="python:request.user.username != 'anonymous'">
142144
<b i18n:translate="">Hello, <span i18n:name="user"
143145
tal:replace="request/user/username">username</span></b><br>
144-
<a href="#" tal:attributes="href string:issue?@sort=-activity&@group=priority&@filter=status,assignedto&@columns=id,activity,title,creator,status&status=-1,1,2,3,4,5,6,7&assignedto=${request/user/id}" i18n:translate="">Your Issues</a><br>
145146
<a href="#" tal:attributes="href string:user${request/user/id}"
146147
i18n:translate="">Your Details</a><br>
147148
<a href="#" tal:attributes="href python:request.indexargs_url('',

0 commit comments

Comments
 (0)