add sanity check for sort and group on same property [SF#1033477]

Author: Richard Jones

CHANGES.txt

@@ -41,6 +41,7 @@ Fixed:
 - mailgw can override the MAIL_DEFAULT_CLASS
 - handle Py2.3+ datetime objects as Date specs (sf bug 971300)
 - use row locking in MySQL newid() (sf bug 1034211)
+- add sanity check for sort and group on same property (sf bug 1033477)
 
 
 2004-07-21 0.7.6

roundup/backends/back_mysql.py

@@ -651,6 +651,10 @@ def filter(self, search_matches, filterspec, sort=(None,None),
             where.append('_%s.id in (%s)'%(cn, s))
             args = args + v
 
+        # sanity check: sorting *and* grouping on the same property?
+        if group[1] == sort[1]:
+            sort = (None, None)
+
         # "grouping" is just the first-order sorting in the SQL fetch
         orderby = []
         ordercols = []

roundup/backends/rdbms_common.py

@@ -1,4 +1,4 @@
-# $Id: rdbms_common.py,v 1.131 2004-09-26 14:38:54 a1s Exp $
+# $Id: rdbms_common.py,v 1.132 2004-10-07 06:08:42 richard Exp $
 ''' Relational database (SQL) backend common code.
 
 Basics:
@@ -2154,6 +2154,10 @@ def filter(self, search_matches, filterspec, sort=(None,None),
             where.append('_%s.id in (%s)'%(cn, s))
             args = args + v
 
+        # sanity check: sorting *and* grouping on the same property?
+        if group[1] == sort[1]:
+            sort = (None, None)
+
         # "grouping" is just the first-order sorting in the SQL fetch
         orderby = []
         ordercols = []