nicer page title

Richard Jones · Richard Jones · commit 0ca321133b13 · 2002-09-06T05:33:09.000Z
diff --git a/TODO.txt b/TODO.txt
@@ -49,7 +49,6 @@ pending web: have roundup.cgi pick up instance config from the environment
 pending web: UNIX init.d script for roundup-server
 pending web: modify cgitb to handle PageTemplate errors better (see how 
              Zope handles __traceback_supplement__ and __traceback_info__)
-pending web: title is stoopid
 pending web: rewritten documentation (can come after the beta though so stuff
              is settled) ... including relevant file names in customisation doc
 
diff --git a/roundup/cgi/templating.py b/roundup/cgi/templating.py
@@ -1075,6 +1075,19 @@ def update(self, kwargs):
         if kwargs.has_key('columns'):
             self.show = ShowDict(self.columns)
 
+    def description(self):
+        ''' Return a description of the request - handle for the page title.
+        '''
+        s = [self.client.db.config.INSTANCE_NAME]
+        if self.classname:
+            if self.client.nodeid:
+                s.append('- %s%s'%(self.classname, self.client.nodeid))
+            else:
+                s.append('- index of '+self.classname)
+        else:
+            s.append('- home')
+        return ' '.join(s)
+
     def __str__(self):
         d = {}
         d.update(self.__dict__)
diff --git a/roundup/templates/classic/html/page b/roundup/templates/classic/html/page
@@ -1,4 +1,4 @@
-<html tal:define="title string:${db/config/INSTANCE_NAME} - ${request/classname}">
+<html tal:define="title request/description">
 <head>
 <title tal:content="title">title goes here</title>
 

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-<html tal:define="title string:${db/config/INSTANCE_NAME} - ${request/classname}">`
	`1`	`+<html tal:define="title request/description">`
`2`	`2`	`<head>`
`3`	`3`	`<title tal:content="title">title goes here</title>`
`4`	`4`