Skip to content

Commit 0c7cf54

Browse files
committed
refactor: issue2551293 - remove schema_hook from Tracker instance.
Not used, obsolete.
1 parent 67b2966 commit 0c7cf54

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

CHANGES.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,9 @@ Fixed:
4747
source install. (John Rouillard)
4848
- Document use of pyreadline3 to allow roundup-admin to have CLI editing
4949
on windows. (John Rouillard)
50+
- issue2551293 - remove schema_hook from Tracker instance. Looks like
51+
it was an obsolete hook used for testing. Never documented and not
52+
accessible from schema.py.
5053

5154
Features:
5255

roundup/instance.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,6 @@ def __init__(self, tracker_home, optimize=0):
6161
"""
6262
self.tracker_home = tracker_home
6363
self.optimize = optimize
64-
# if set, call schema_hook after executing schema.py will get
65-
# same variables (in particular db) as schema.py main purpose is
66-
# for regression tests
67-
self.schema_hook = None
6864
self.config = configuration.CoreConfig(tracker_home)
6965
self.actions = {}
7066
self.cgi_actions = {}
@@ -118,15 +114,11 @@ def open(self, name=None):
118114
if self.optimize:
119115
# execute preloaded schema object
120116
self._exec(self.schema, env)
121-
if isinstance(self.schema_hook, Callable):
122-
self.schema_hook(**env)
123117
# use preloaded detectors
124118
detectors = self.detectors
125119
else:
126120
# execute the schema file
127121
self._execfile('schema.py', env)
128-
if isinstance(self.schema_hook, Callable):
129-
self.schema_hook(**env)
130122
# reload extensions and detectors
131123
for extension in self.get_extensions('extensions'):
132124
extension(self)

0 commit comments

Comments
 (0)