Try to deal with this warning/error: DeprecationWarning: generator

rouilj · rouilj · commit 0527a2774d36 · 2019-06-12T19:38:33.000-04:00
'iter_roles' raised StopIteration

PEP479 specifies how to rework it by using return rather than raise
StopIteration.

I am not sure if this is right, but
test/test_cgi.py::FormTestCase::testRoles is still passing.
diff --git a/roundup/hyperdb.py b/roundup/hyperdb.py
@@ -35,7 +35,6 @@
 
 logger = logging.getLogger('roundup.hyperdb')
 
-
 #
 # Types
 #
@@ -837,7 +836,7 @@ def iter_roles(roles):
         into something python can use more easily
     '''
     if not roles or not roles.strip():
-        raise StopIteration("Empty roles given")
+        return
     for role in [x.lower().strip() for x in roles.split(',')]:
         yield role
 

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,6 @@`
`35`	`35`
`36`	`36`	`logger = logging.getLogger('roundup.hyperdb')`
`37`	`37`
`38`		`-`
`39`	`38`	`#`
`40`	`39`	`# Types`
`41`	`40`	`#`
`@@ -837,7 +836,7 @@ def iter_roles(roles):`
`837`	`836`	`into something python can use more easily`
`838`	`837`	`'''`
`839`	`838`	`if not roles or not roles.strip():`
`840`		`- raise StopIteration("Empty roles given")`
	`839`	`+ return`
`841`	`840`	`for role in [x.lower().strip() for x in roles.split(',')]:`
`842`	`841`	`yield role`
`843`	`842`