fix: issue2550962. remove assert in Role::hasPermission

issue2550962 - Check uses of assert in roundup code.

An assert was used to make sure that a classname always accompoanied
an itemid in hasPermission. The Security::hasPErmission has an if
clause that does the same check and raises a ValueError.

Remove asserts because they ae removed when running python in
optimized mode.

Author: rouilj

roundup/security.py

@@ -267,7 +267,9 @@ def filter_iter (self, permission, classname):
 
     def hasPermission (self, db, perm, uid, classname, property, itemid, chk):
         # if itemid is given a classname must, too, checked in caller
-        assert not itemid or classname
+        if itemid and classname is None:
+            raise ValueError('classname must accompany itemid')
+
         perms = self._permissions
         if perm not in perms:
             return False