Fix token_split() so its one error throws ValueError w/out extra arg.

In Python 3, raise has to throw a single object value without extra
arguments.  This commit also checked the function's callsites. One
needed armoring, didn't have it, and got it.  There didn't seem to be
anything to do about the other than add a warning comment.

All tests pass.

Author: eric-s-raymond

roundup/admin.py

@@ -1555,7 +1555,10 @@ def interactive(self):
                 print _('exit...')
                 break
             if not command: continue
-            args = token.token_split(command)
+            try:
+                args = token.token_split(command)
+            except ValueError:
+                continue	# Ignore invalid quoted token
             if not args: continue
             if args[0] in ('quit', 'exit'): break
             self.run_command(args)

roundup/cgi/actions.py

@@ -402,6 +402,7 @@ def fakeFilterVars(self):
                     continue
                 if isinstance(prop, hyperdb.String):
                     v = self.form[key].value
+                    # If this ever has unbalanced quotes, hilarity will ensue
                     l = token.token_split(v)
                     if len(l) != 1 or l[0] != v:
                         self.form.value.remove(self.form[key])

roundup/token.py

@@ -54,7 +54,7 @@ def token_split(s, whitespace=' \r\n\t', quotes='\'"',
     while 1:
         # end of string, finish off the current token
         if pos == length:
-            if state == QUOTE: raise ValueError, "unmatched quote"
+            if state == QUOTE: raise ValueError
             elif state == TOKEN: l.append(token)
             break
         c = s[pos]