hotwired/turbo support and fixes issue with duplicate events in GTM#160
Merged
DonSchado merged 3 commits intorailslove:masterfrom Jul 12, 2021
gunpowderlabs:turbo
Merged
hotwired/turbo support and fixes issue with duplicate events in GTM#160DonSchado merged 3 commits intorailslove:masterfrom gunpowderlabs:turbo
DonSchado merged 3 commits intorailslove:masterfrom
gunpowderlabs:turbo
Conversation
wrozka
changed the title
|
Any update when this feature will be available in rack-tracker? |
Collaborator
|
@karthikkasturi thanks for the reminder. @wrozka @karthikkasturi are you able to test this revision against a production setup? |
Contributor
Author
|
@DonSchado Yes, we're using this on production |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new
turbo-railsgem that supersedesturbolinks. It observes both turbo and turbolinks events.Also, this PR fixes issue with multiple event listeners tracking stale events and duplicate page views. Since turbo (and turbolinks) are evaluating new scripts from the
headelement, it ends up registering a duplicate event listener any time a new event is pushed from the backend. This PR fixes that by generating a static script with the turbo event listener (it will be evaluated only once) and a dynamic script with backend events (its going be evaluated on every load if any events are present).