From e8334e03c7792b926a3cc1a2fb123585b8fd2423 Mon Sep 17 00:00:00 2001 From: Eugene Korneev Date: Sat, 19 Sep 2015 01:09:52 +0300 Subject: [PATCH 1/2] Support JSON values for Google Tag Manager --- lib/rack/tracker/google_tag_manager/google_tag_manager.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rack/tracker/google_tag_manager/google_tag_manager.rb b/lib/rack/tracker/google_tag_manager/google_tag_manager.rb index be01ed7..c4fadf7 100644 --- a/lib/rack/tracker/google_tag_manager/google_tag_manager.rb +++ b/lib/rack/tracker/google_tag_manager/google_tag_manager.rb @@ -3,7 +3,7 @@ class Rack::Tracker::GoogleTagManager < Rack::Tracker::Handler class Push < OpenStruct def write - "'#{event[:name]}': '#{event[:value]}'" + "'#{event[:name]}': #{event[:value].to_json}" end def event From 317b33d5e7a409e06e4ae0f32438c97ae6d33f4f Mon Sep 17 00:00:00 2001 From: Eugene Korneev Date: Thu, 24 Sep 2015 05:19:31 +0300 Subject: [PATCH 2/2] Dirty hack for lobster needs --- lib/rack/tracker/google_tag_manager/google_tag_manager.rb | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/rack/tracker/google_tag_manager/google_tag_manager.rb b/lib/rack/tracker/google_tag_manager/google_tag_manager.rb index c4fadf7..38c9120 100644 --- a/lib/rack/tracker/google_tag_manager/google_tag_manager.rb +++ b/lib/rack/tracker/google_tag_manager/google_tag_manager.rb @@ -3,7 +3,11 @@ class Rack::Tracker::GoogleTagManager < Rack::Tracker::Handler class Push < OpenStruct def write - "'#{event[:name]}': #{event[:value].to_json}" + if event[:value].match(/":/).present? + "'#{event[:name]}': #{event[:value]}" + else + "'#{event[:name]}': '#{event[:value]}'" + end end def event